Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: Source/bindings/templates/interface.cpp

Issue 724183004: Simplify Dictionary::ConversionContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index b1b0ebbb39ec09ef587bc8638920b1c86f50c436..41d0bfbe15a71678753e988424c0544f5a7649d3 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -617,11 +617,11 @@ static const V8DOMConfiguration::AttributeConfiguration shadowAttributes[] = {
{##############################################################################}
{% block initialize_event %}
{% if has_event_constructor %}
-bool initialize{{cpp_class}}({{cpp_class}}Init& eventInit, const Dictionary& options, ExceptionState& exceptionState, const v8::FunctionCallbackInfo<v8::Value>& info, const String& forEventName)
+bool initialize{{cpp_class}}({{cpp_class}}Init& eventInit, const Dictionary& options, ExceptionState& exceptionState, const v8::FunctionCallbackInfo<v8::Value>& info)
{
- Dictionary::ConversionContext conversionContext(forEventName.isEmpty() ? String("{{interface_name}}") : forEventName, "", exceptionState);
+ Dictionary::ConversionContext conversionContext(exceptionState);
{% if parent_interface %}{# any Event interface except Event itself #}
- if (!initialize{{parent_interface}}(eventInit, options, exceptionState, info, forEventName.isEmpty() ? String("{{interface_name}}") : forEventName))
+ if (!initialize{{parent_interface}}(eventInit, options, exceptionState, info))
return false;
{% endif %}
« no previous file with comments | « Source/bindings/templates/interface.h ('k') | Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698