Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 724183004: Simplify Dictionary::ConversionContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 {% endfor %} 610 {% endfor %}
611 }; 611 };
612 612
613 {% endif %} 613 {% endif %}
614 {% endblock %} 614 {% endblock %}
615 615
616 616
617 {##############################################################################} 617 {##############################################################################}
618 {% block initialize_event %} 618 {% block initialize_event %}
619 {% if has_event_constructor %} 619 {% if has_event_constructor %}
620 bool initialize{{cpp_class}}({{cpp_class}}Init& eventInit, const Dictionary& opt ions, ExceptionState& exceptionState, const v8::FunctionCallbackInfo<v8::Value>& info, const String& forEventName) 620 bool initialize{{cpp_class}}({{cpp_class}}Init& eventInit, const Dictionary& opt ions, ExceptionState& exceptionState, const v8::FunctionCallbackInfo<v8::Value>& info)
621 { 621 {
622 Dictionary::ConversionContext conversionContext(forEventName.isEmpty() ? Str ing("{{interface_name}}") : forEventName, "", exceptionState); 622 Dictionary::ConversionContext conversionContext(exceptionState);
623 {% if parent_interface %}{# any Event interface except Event itself #} 623 {% if parent_interface %}{# any Event interface except Event itself #}
624 if (!initialize{{parent_interface}}(eventInit, options, exceptionState, info , forEventName.isEmpty() ? String("{{interface_name}}") : forEventName)) 624 if (!initialize{{parent_interface}}(eventInit, options, exceptionState, info ))
625 return false; 625 return false;
626 626
627 {% endif %} 627 {% endif %}
628 {% for attribute in attributes 628 {% for attribute in attributes
629 if (attribute.is_initialized_by_event_constructor and 629 if (attribute.is_initialized_by_event_constructor and
630 not attribute.idl_type == 'any')%} 630 not attribute.idl_type == 'any')%}
631 {% set is_nullable = 'true' if attribute.is_nullable else 'false' %} 631 {% set is_nullable = 'true' if attribute.is_nullable else 'false' %}
632 {% if attribute.deprecate_as %} 632 {% if attribute.deprecate_as %}
633 if (DictionaryHelper::convert(options, conversionContext.setConversionType(" {{attribute.idl_type}}", {{is_nullable}}), "{{attribute.name}}", eventInit.{{att ribute.cpp_name}})) { 633 if (DictionaryHelper::convert(options, conversionContext.setConversionType(" {{attribute.idl_type}}", {{is_nullable}}), "{{attribute.name}}", eventInit.{{att ribute.cpp_name}})) {
634 if (options.hasProperty("{{attribute.name}}")) 634 if (options.hasProperty("{{attribute.name}}"))
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 } 984 }
985 985
986 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 986 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
987 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 987 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
988 { 988 {
989 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 989 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
990 } 990 }
991 {% endfor %} 991 {% endfor %}
992 {% endif %} 992 {% endif %}
993 {% endblock %} 993 {% endblock %}
OLDNEW
« no previous file with comments | « Source/bindings/templates/interface.h ('k') | Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698