Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

Issue 724183004: Simplify Dictionary::ConversionContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp
index 69c57d6d16b7f32efcbbced57d7d041ef8e37937..808d31081ebef69634af8fd3d996501d361e1d9f 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp
@@ -279,10 +279,10 @@ static const V8DOMConfiguration::AttributeConfiguration V8TestInterfaceEventCons
{"deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttribute", TestInterfaceEventConstructorV8Internal::deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttributeAttributeGetterCallback, 0, 0, 0, 0, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), V8DOMConfiguration::ExposedToAllScripts, V8DOMConfiguration::OnInstance},
};
-bool initializeTestInterfaceEventConstructor(TestInterfaceEventConstructorInit& eventInit, const Dictionary& options, ExceptionState& exceptionState, const v8::FunctionCallbackInfo<v8::Value>& info, const String& forEventName)
+bool initializeTestInterfaceEventConstructor(TestInterfaceEventConstructorInit& eventInit, const Dictionary& options, ExceptionState& exceptionState, const v8::FunctionCallbackInfo<v8::Value>& info)
{
- Dictionary::ConversionContext conversionContext(forEventName.isEmpty() ? String("TestInterfaceEventConstructor") : forEventName, "", exceptionState);
- if (!initializeEvent(eventInit, options, exceptionState, info, forEventName.isEmpty() ? String("TestInterfaceEventConstructor") : forEventName))
+ Dictionary::ConversionContext conversionContext(exceptionState);
+ if (!initializeEvent(eventInit, options, exceptionState, info))
return false;
if (!DictionaryHelper::convert(options, conversionContext.setConversionType("DOMString", false), "initializedByEventConstructorReadonlyStringAttribute", eventInit.initializedByEventConstructorReadonlyStringAttribute))
« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698