Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: Source/bindings/core/v8/Dictionary.h

Issue 724183004: Simplify Dictionary::ConversionContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/Dictionary.h
diff --git a/Source/bindings/core/v8/Dictionary.h b/Source/bindings/core/v8/Dictionary.h
index 13cdde933b082096a2a179f6cf99cd3b2481ed00..cbc87ce0d943023219b1e5ad35fdc5101cbe1c37 100644
--- a/Source/bindings/core/v8/Dictionary.h
+++ b/Source/bindings/core/v8/Dictionary.h
@@ -76,18 +76,13 @@ public:
class ConversionContext {
public:
- ConversionContext(const String& interfaceName, const String& methodName, ExceptionState& exceptionState)
- : m_interfaceName(interfaceName)
- , m_methodName(methodName)
- , m_exceptionState(exceptionState)
+ explicit ConversionContext(ExceptionState& exceptionState)
+ : m_exceptionState(exceptionState)
, m_dirty(true)
{
resetPerPropertyContext();
}
- const String& interfaceName() const { return m_interfaceName; }
- const String& methodName() const { return m_methodName; }
- bool forConstructor() const { return m_methodName.isEmpty(); }
ExceptionState& exceptionState() const { return m_exceptionState; }
bool isNullable() const { return m_isNullable; }
@@ -100,8 +95,6 @@ public:
void resetPerPropertyContext();
private:
- const String m_interfaceName;
- const String m_methodName;
ExceptionState& m_exceptionState;
bool m_dirty;
@@ -111,7 +104,7 @@ public:
class ConversionContextScope {
public:
- ConversionContextScope(ConversionContext& context)
+ explicit ConversionContextScope(ConversionContext& context)
: m_context(context) { }
~ConversionContextScope()
{
« no previous file with comments | « no previous file | Source/bindings/templates/interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698