Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 722723003: Re-land 714393002 after fixing android build. (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
jamesr, qsr
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Re-land 714393002 after fixing android build. Original CL: https://codereview.chromium.org/714393002 Reverted in: https://codereview.chromium.org/719063002 One fix was to use static_assert instead of _Static_assert in COMPILE_ASSERT. _Static_assert is C11, static_assert is C++11 and Android's stdlib doesn't have C11 support, but we don't care since we never use COMPILE_ASSERT in plain C code. The second fix was also for the android STL and was adding back the nullptr_t type definition in NullPtr.h for old versions of STL. I compile this locally for android to verify that it works mojo/tools/mojob.py build --android TBR=jamesr@chromium.org,qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/756893a57c79bdb2d3bdfa93ec8b62f75f7af927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1090 lines) Patch
M sky/engine/bindings/core/v8/ScriptWrappable.h View 1 chunk +0 lines, -20 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptWrappable.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/config.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/ElementData.h View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/html/parser/MarkupTokenizerInlines.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/platform/Length.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/platform/PlatformExport.h View 1 chunk +0 lines, -21 lines 0 comments Download
M sky/engine/platform/exported/WebCursorInfo.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/platform/fonts/FontPlatformData.h View 1 chunk +0 lines, -149 lines 0 comments Download
M sky/engine/platform/fonts/GlyphPage.h View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/platform/graphics/Color.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/Image.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/transforms/TransformationMatrix.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/platform/weborigin/KURL.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/platform/weborigin/KURL.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/public/platform/Platform.h View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/public/platform/WebCommon.h View 3 chunks +3 lines, -35 lines 0 comments Download
M sky/engine/wtf/Alignment.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/wtf/Assertions.h View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/wtf/Assertions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/wtf/Atomics.h View 3 chunks +0 lines, -47 lines 0 comments Download
M sky/engine/wtf/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/wtf/BitwiseOperations.h View 1 chunk +1 line, -24 lines 0 comments Download
M sky/engine/wtf/ByteSwap.h View 2 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/wtf/CPU.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/wtf/Compiler.h View 6 chunks +1 line, -84 lines 0 comments Download
M sky/engine/wtf/EnumClass.h View 1 chunk +0 lines, -70 lines 0 comments Download
M sky/engine/wtf/HashFunctions.h View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/wtf/InstanceCounter.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M sky/engine/wtf/NullPtr.h View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/engine/wtf/NullPtr.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M sky/engine/wtf/OwnPtr.h View 5 chunks +0 lines, -19 lines 0 comments Download
M sky/engine/wtf/RefPtr.h View 3 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/wtf/RefPtrTest.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
D sky/engine/wtf/RetainPtr.h View 1 chunk +0 lines, -309 lines 0 comments Download
M sky/engine/wtf/TypeTraits.h View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/wtf/TypeTraits.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/wtf/Vector.h View 3 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/wtf/WTFExport.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/wtf/dtoa.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/wtf/dtoa/utils.h View 1 chunk +0 lines, -22 lines 0 comments Download
M sky/engine/wtf/testing/WTFUnitTestHelpersExport.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/wtf/text/StringImpl.h View 3 chunks +0 lines, -16 lines 0 comments Download
M sky/engine/wtf/text/StringOperatorsTest.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M sky/engine/wtf/text/WTFString.cpp View 3 chunks +0 lines, -13 lines 0 comments Download
M sky/viewer/cc/sky_viewer_cc_export.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
6 years, 1 month ago (2014-11-12 19:54:23 UTC) #1
eseidel
Committed patchset #1 (id:1) manually as 756893a57c79bdb2d3bdfa93ec8b62f75f7af927.
6 years, 1 month ago (2014-11-12 20:16:09 UTC) #2
qsr
6 years, 1 month ago (2014-11-13 10:20:33 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698