Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 719063002: Revert "Remove support for MSVC" (Closed)

Created:
6 years, 1 month ago by qsr
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium, jamesr
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1070 lines, -10 lines) Patch
M sky/engine/bindings/core/v8/ScriptWrappable.h View 1 chunk +20 lines, -0 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptWrappable.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/engine/config.h View 1 chunk +4 lines, -0 lines 0 comments Download
M sky/engine/core/dom/ElementData.h View 2 chunks +9 lines, -0 lines 0 comments Download
M sky/engine/core/html/parser/MarkupTokenizerInlines.h View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/engine/platform/Length.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/platform/PlatformExport.h View 1 chunk +21 lines, -0 lines 0 comments Download
M sky/engine/platform/exported/WebCursorInfo.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/engine/platform/fonts/FontPlatformData.h View 1 chunk +149 lines, -0 lines 0 comments Download
M sky/engine/platform/fonts/GlyphPage.h View 2 chunks +9 lines, -0 lines 0 comments Download
M sky/engine/platform/graphics/Color.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/platform/graphics/Image.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/platform/transforms/TransformationMatrix.h View 1 chunk +4 lines, -0 lines 0 comments Download
M sky/engine/platform/weborigin/KURL.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/platform/weborigin/KURL.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/public/platform/Platform.h View 2 chunks +9 lines, -0 lines 0 comments Download
M sky/engine/public/platform/WebCommon.h View 3 chunks +35 lines, -3 lines 0 comments Download
M sky/engine/wtf/Alignment.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/engine/wtf/Assertions.h View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/engine/wtf/Assertions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/wtf/Atomics.h View 3 chunks +47 lines, -0 lines 0 comments Download
M sky/engine/wtf/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/wtf/BitwiseOperations.h View 1 chunk +24 lines, -1 line 0 comments Download
M sky/engine/wtf/ByteSwap.h View 2 chunks +14 lines, -0 lines 0 comments Download
M sky/engine/wtf/CPU.h View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/wtf/Compiler.h View 6 chunks +84 lines, -1 line 1 comment Download
M sky/engine/wtf/EnumClass.h View 1 chunk +70 lines, -0 lines 0 comments Download
M sky/engine/wtf/HashFunctions.h View 2 chunks +11 lines, -0 lines 0 comments Download
M sky/engine/wtf/InstanceCounter.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M sky/engine/wtf/NullPtr.h View 1 chunk +39 lines, -0 lines 0 comments Download
A + sky/engine/wtf/NullPtr.cpp View 2 chunks +14 lines, -1 line 0 comments Download
M sky/engine/wtf/OwnPtr.h View 5 chunks +19 lines, -0 lines 0 comments Download
M sky/engine/wtf/RefPtr.h View 3 chunks +4 lines, -0 lines 0 comments Download
M sky/engine/wtf/RefPtrTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
A sky/engine/wtf/RetainPtr.h View 1 chunk +309 lines, -0 lines 0 comments Download
M sky/engine/wtf/TypeTraits.h View 2 chunks +6 lines, -0 lines 0 comments Download
M sky/engine/wtf/TypeTraits.cpp View 3 chunks +6 lines, -0 lines 0 comments Download
M sky/engine/wtf/Vector.h View 3 chunks +4 lines, -0 lines 0 comments Download
M sky/engine/wtf/WTFExport.h View 1 chunk +8 lines, -0 lines 0 comments Download
M sky/engine/wtf/dtoa.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/engine/wtf/dtoa/utils.h View 1 chunk +22 lines, -0 lines 0 comments Download
M sky/engine/wtf/testing/WTFUnitTestHelpersExport.h View 1 chunk +8 lines, -0 lines 0 comments Download
M sky/engine/wtf/text/StringImpl.h View 3 chunks +16 lines, -0 lines 0 comments Download
M sky/engine/wtf/text/StringOperatorsTest.cpp View 1 chunk +35 lines, -0 lines 0 comments Download
M sky/engine/wtf/text/WTFString.cpp View 3 chunks +13 lines, -0 lines 0 comments Download
M sky/viewer/cc/sky_viewer_cc_export.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qsr
6 years, 1 month ago (2014-11-12 12:30:53 UTC) #1
qsr
Committed patchset #1 (id:1) manually as 530ed707135ea8355283704b56c72c937adad49a.
6 years, 1 month ago (2014-11-12 12:31:15 UTC) #2
eseidel
https://codereview.chromium.org/719063002/diff/1/sky/engine/wtf/Compiler.h File sky/engine/wtf/Compiler.h (right): https://codereview.chromium.org/719063002/diff/1/sky/engine/wtf/Compiler.h#newcode98 sky/engine/wtf/Compiler.h:98: #define WTF_COMPILER_SUPPORTS_C_STATIC_ASSERT 1 So this is the change which ...
6 years, 1 month ago (2014-11-12 19:13:11 UTC) #3
eseidel
6 years, 1 month ago (2014-11-12 19:13:54 UTC) #4
Message was sent while issue was closed. 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698