Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 714393002: Remove support for MSVC (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, jamesr, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove support for MSVC I also removed COMPILER_SUPPORTS since all of the checks were for old versions of GCC which we no longer support. Mojo requires GCC 4.8 or later. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d9cfbefcfe8710f1cb190ae817757853c8058797

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1090 lines) Patch
M sky/engine/bindings/core/v8/ScriptWrappable.h View 1 chunk +0 lines, -20 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptWrappable.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/config.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/ElementData.h View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/html/parser/MarkupTokenizerInlines.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/platform/Length.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/platform/PlatformExport.h View 1 chunk +0 lines, -21 lines 0 comments Download
M sky/engine/platform/exported/WebCursorInfo.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/platform/fonts/FontPlatformData.h View 1 chunk +0 lines, -149 lines 0 comments Download
M sky/engine/platform/fonts/GlyphPage.h View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/platform/graphics/Color.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/Image.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/transforms/TransformationMatrix.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/platform/weborigin/KURL.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/platform/weborigin/KURL.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/public/platform/Platform.h View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/public/platform/WebCommon.h View 3 chunks +3 lines, -35 lines 0 comments Download
M sky/engine/wtf/Alignment.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/wtf/Assertions.h View 1 chunk +0 lines, -6 lines 1 comment Download
M sky/engine/wtf/Assertions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/wtf/Atomics.h View 3 chunks +0 lines, -47 lines 0 comments Download
M sky/engine/wtf/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/wtf/BitwiseOperations.h View 1 chunk +1 line, -24 lines 0 comments Download
M sky/engine/wtf/ByteSwap.h View 2 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/wtf/CPU.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/wtf/Compiler.h View 6 chunks +1 line, -84 lines 0 comments Download
M sky/engine/wtf/EnumClass.h View 1 chunk +0 lines, -70 lines 0 comments Download
M sky/engine/wtf/HashFunctions.h View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/wtf/InstanceCounter.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M sky/engine/wtf/NullPtr.h View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/engine/wtf/NullPtr.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M sky/engine/wtf/OwnPtr.h View 5 chunks +0 lines, -19 lines 0 comments Download
M sky/engine/wtf/RefPtr.h View 3 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/wtf/RefPtrTest.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
D sky/engine/wtf/RetainPtr.h View 1 chunk +0 lines, -309 lines 0 comments Download
M sky/engine/wtf/TypeTraits.h View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/wtf/TypeTraits.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/wtf/Vector.h View 3 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/wtf/WTFExport.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/wtf/dtoa.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/wtf/dtoa/utils.h View 1 chunk +0 lines, -22 lines 0 comments Download
M sky/engine/wtf/testing/WTFUnitTestHelpersExport.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/wtf/text/StringImpl.h View 3 chunks +0 lines, -16 lines 0 comments Download
M sky/engine/wtf/text/StringOperatorsTest.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M sky/engine/wtf/text/WTFString.cpp View 3 chunks +0 lines, -13 lines 0 comments Download
M sky/viewer/cc/sky_viewer_cc_export.h View 1 chunk +0 lines, -9 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
eseidel
6 years, 1 month ago (2014-11-12 00:15:59 UTC) #1
eseidel
https://codereview.chromium.org/714393002/diff/1/sky/engine/wtf/Assertions.h File sky/engine/wtf/Assertions.h (left): https://codereview.chromium.org/714393002/diff/1/sky/engine/wtf/Assertions.h#oldcode288 sky/engine/wtf/Assertions.h:288: #elif COMPILER_SUPPORTS(CXX_STATIC_ASSERT) This isn't needed because both are always ...
6 years, 1 month ago (2014-11-12 00:20:34 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/714393002/diff/1/sky/viewer/cc/sky_viewer_cc_export.h File sky/viewer/cc/sky_viewer_cc_export.h (right): https://codereview.chromium.org/714393002/diff/1/sky/viewer/cc/sky_viewer_cc_export.h#newcode11 sky/viewer/cc/sky_viewer_cc_export.h:11: #define SKY_VIEWER_CC_EXPORT __attribute__((visibility("default"))) You can remove all this ...
6 years, 1 month ago (2014-11-12 00:28:14 UTC) #3
eseidel
6 years, 1 month ago (2014-11-12 00:59:08 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d9cfbefcfe8710f1cb190ae817757853c8058797.

Powered by Google App Engine
This is Rietveld 408576698