Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: sky/engine/wtf/RefPtrTest.cpp

Issue 722723003: Re-land 714393002 after fixing android build. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/wtf/RefPtr.h ('k') | sky/engine/wtf/RetainPtr.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "wtf/RefPtr.h" 6 #include "wtf/RefPtr.h"
7 7
8 #include "wtf/text/StringImpl.h" 8 #include "wtf/text/StringImpl.h"
9 #include <gtest/gtest.h> 9 #include <gtest/gtest.h>
10 10
11 namespace { 11 namespace {
12 12
13 TEST(RefPtrTest, Basic) 13 TEST(RefPtrTest, Basic)
14 { 14 {
15 RefPtr<StringImpl> string; 15 RefPtr<StringImpl> string;
16 EXPECT_TRUE(!string); 16 EXPECT_TRUE(!string);
17 string = StringImpl::create("test"); 17 string = StringImpl::create("test");
18 EXPECT_TRUE(!!string); 18 EXPECT_TRUE(!!string);
19 string.clear(); 19 string.clear();
20 EXPECT_TRUE(!string); 20 EXPECT_TRUE(!string);
21 } 21 }
22 22
23 #if COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES)
24 TEST(RefPtrTest, MoveAssignmentOperator) 23 TEST(RefPtrTest, MoveAssignmentOperator)
25 { 24 {
26 RefPtr<StringImpl> a = StringImpl::create("a"); 25 RefPtr<StringImpl> a = StringImpl::create("a");
27 RefPtr<StringImpl> b = StringImpl::create("b"); 26 RefPtr<StringImpl> b = StringImpl::create("b");
28 // FIXME: Instead of explicitly casting to RefPtr<StringImpl>&& here, we sho uld use std::move, but that 27 // FIXME: Instead of explicitly casting to RefPtr<StringImpl>&& here, we sho uld use std::move, but that
29 // requires us to have a standard library that supports move semantics. 28 // requires us to have a standard library that supports move semantics.
30 b = static_cast<RefPtr<StringImpl>&&>(a); 29 b = static_cast<RefPtr<StringImpl>&&>(a);
31 EXPECT_TRUE(!!b); 30 EXPECT_TRUE(!!b);
32 EXPECT_TRUE(!a); 31 EXPECT_TRUE(!a);
33 } 32 }
34 #endif
35 33
36 } 34 }
OLDNEW
« no previous file with comments | « sky/engine/wtf/RefPtr.h ('k') | sky/engine/wtf/RetainPtr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698