Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 709193003: Don't require getPropertyCSSValue in css3-text getComputedStyle tests (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't require getPropertyCSSValue in css3-text getComputedStyle tests As getPropertyCSSValue is no longer web-exposed we should stop testing it so we can delete the interface. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -494 lines) Patch
M LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt View 1 chunk +18 lines, -18 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last.js View 3 chunks +7 lines, -9 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last-inherited.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt View 1 chunk +26 lines, -68 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt View 1 chunk +25 lines, -67 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt View 1 chunk +24 lines, -64 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt View 1 chunk +20 lines, -35 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-color.js View 2 chunks +19 lines, -36 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js View 1 chunk +20 lines, -61 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-style.js View 2 chunks +19 lines, -36 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js View 2 chunks +17 lines, -47 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
I cleaned up some of the tests a little, although I probably won't bother doing ...
6 years, 1 month ago (2014-11-08 01:54:16 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-08 02:20:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709193003/1
6 years, 1 month ago (2014-11-08 02:21:46 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 03:06:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184997

Powered by Google App Engine
This is Rietveld 408576698