Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt

Issue 709193003: Don't require getPropertyCSSValue in css3-text getComputedStyle tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt
diff --git a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt
index e6ed8942f7d176b7684ac6f79e8d1fb813030782..ee70b80ca2a30f315dd7bb8de18a62b466ef1936 100644
--- a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt
+++ b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt
@@ -1,97 +1,55 @@
-Test to make sure text-decoration-line property returns values properly.
+Test to make sure text-decoration-line is computed properly.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Initial value:
-PASS e.style.getPropertyCSSValue('text-decoration-line') is null
-PASS computedStyle.textDecorationLine is 'none'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'none'
+PASS e.style.textDecorationLine is ""
+PASS computedStyle.textDecorationLine is "none"
Initial value (explicit):
-PASS e.style.textDecorationLine is 'initial'
-PASS e.style.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-line').cssText is 'initial'
-PASS computedStyle.textDecorationLine is 'none'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'none'
+PASS e.style.textDecorationLine is "initial"
+PASS computedStyle.textDecorationLine is "none"
Value 'none':
-PASS e.style.textDecorationLine is 'none'
-PASS e.style.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-line').cssText is 'none'
-PASS computedStyle.textDecorationLine is 'none'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'none'
+PASS e.style.textDecorationLine is "none"
+PASS computedStyle.textDecorationLine is "none"
Value 'underline':
-PASS e.style.textDecorationLine is 'underline'
-PASS e.style.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS e.style.getPropertyCSSValue('text-decoration-line').cssText is 'underline'
-PASS computedStyle.textDecorationLine is 'underline'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'underline'
+PASS e.style.textDecorationLine is "underline"
+PASS computedStyle.textDecorationLine is "underline"
Value 'overline':
-PASS e.style.textDecorationLine is 'overline'
-PASS e.style.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS e.style.getPropertyCSSValue('text-decoration-line').cssText is 'overline'
-PASS computedStyle.textDecorationLine is 'overline'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'overline'
+PASS e.style.textDecorationLine is "overline"
+PASS computedStyle.textDecorationLine is "overline"
Value 'line-through':
-PASS e.style.textDecorationLine is 'line-through'
-PASS e.style.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS e.style.getPropertyCSSValue('text-decoration-line').cssText is 'line-through'
-PASS computedStyle.textDecorationLine is 'line-through'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'line-through'
+PASS e.style.textDecorationLine is "line-through"
+PASS computedStyle.textDecorationLine is "line-through"
Value 'blink' (valid, but ignored on computed style):
-PASS e.style.textDecorationLine is 'blink'
-PASS e.style.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS e.style.getPropertyCSSValue('text-decoration-line').cssText is 'blink'
-PASS computedStyle.textDecorationLine is 'none'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'none'
+PASS e.style.textDecorationLine is "blink"
+PASS computedStyle.textDecorationLine is "none"
Value 'underline overline line-through blink':
-PASS e.style.textDecorationLine is 'underline overline line-through blink'
-PASS e.style.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS e.style.getPropertyCSSValue('text-decoration-line').cssText is 'underline overline line-through blink'
-PASS computedStyle.textDecorationLine is 'underline overline line-through'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'underline overline line-through'
+PASS e.style.textDecorationLine is "underline overline line-through blink"
+PASS computedStyle.textDecorationLine is "underline overline line-through"
Value '':
-PASS e.style.getPropertyCSSValue('text-decoration-line') is null
-PASS computedStyle.textDecorationLine is 'none'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'none'
+PASS e.style.textDecorationLine is ""
+PASS computedStyle.textDecorationLine is "none"
Parent gets 'underline' value:
-PASS e.style.textDecorationLine is 'underline'
-PASS e.style.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS e.style.getPropertyCSSValue('text-decoration-line').cssText is 'underline'
-PASS computedStyle.textDecorationLine is 'underline'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'underline'
+PASS e.style.textDecorationLine is "underline"
+PASS computedStyle.textDecorationLine is "underline"
Ancestor should explicitly inherit value from parent when 'inherit' value is used:
-PASS e.style.textDecorationLine is 'inherit'
-PASS e.style.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-line').cssText is 'inherit'
-PASS computedStyle.textDecorationLine is 'underline'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSValueList]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'underline'
+PASS e.style.textDecorationLine is "inherit"
+PASS computedStyle.textDecorationLine is "underline"
Ancestor should not implicitly inherit value from parent (i.e. when value is void):
-PASS e.style.getPropertyCSSValue('text-decoration-line') is null
-PASS computedStyle.textDecorationLine is 'none'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-line').cssText is 'none'
+PASS e.style.textDecorationLine is ""
+PASS computedStyle.textDecorationLine is "none"
PASS successfullyParsed is true

Powered by Google App Engine
This is Rietveld 408576698