Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last.js

Issue 709193003: Don't require getPropertyCSSValue in css3-text getComputedStyle tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last.js
diff --git a/LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last.js b/LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last.js
index 0dd7132374c59f8d75a0e6a63004300d35e9f5b0..a75c98290649e3da2e15ac4715a629aaa7cc99ee 100644
--- a/LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last.js
+++ b/LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last.js
@@ -1,22 +1,20 @@
-function testElementStyle(propertyJS, propertyCSS, type, value)
+function testElementStyle(propertyJS, propertyCSS, value)
{
shouldBe("e.style." + propertyJS, "'" + value + "'");
- shouldBe("e.style.getPropertyCSSValue('" + propertyCSS + "').cssText", "'" + value + "'");
}
-function testComputedStyle(propertyJS, propertyCSS, type, value)
+function testComputedStyle(propertyJS, propertyCSS, value)
{
computedStyle = window.getComputedStyle(e, null);
shouldBe("computedStyle." + propertyJS, "'" + value + "'");
- shouldBe("computedStyle.getPropertyCSSValue('" + propertyCSS + "').cssText", "'" + value + "'");
}
function valueSettingTest(value)
{
debug("Value '" + value + "':");
e.style.textAlignLast = value;
- testElementStyle("textAlignLast", "text-align-last", "[object CSSPrimitiveValue]", value);
- testComputedStyle("textAlignLast", "text-align-last", "[object CSSPrimitiveValue]", value);
+ testElementStyle("textAlignLast", "text-align-last", value);
+ testComputedStyle("textAlignLast", "text-align-last", value);
debug('');
}
@@ -24,8 +22,8 @@ function invalidValueSettingTest(value, defaultValue)
{
debug("Invalid value test - '" + value + "':");
e.style.textAlignLast = value;
- testElementStyle("textAlignLast", "text-align-last", "[object CSSPrimitiveValue]", defaultValue);
- testComputedStyle("textAlignLast", "text-align-last", "[object CSSPrimitiveValue]", defaultValue);
+ testElementStyle("textAlignLast", "text-align-last", defaultValue);
+ testComputedStyle("textAlignLast", "text-align-last", defaultValue);
debug('');
}
@@ -34,7 +32,7 @@ description("This test checks that text-align-last parses properly the propertie
e = document.getElementById('test');
debug("Test the initial value:");
-testComputedStyle("textAlignLast", "text-align-last", "[object CSSPrimitiveValue]", 'auto');
+testComputedStyle("textAlignLast", "text-align-last", 'auto');
debug('');
valueSettingTest('start');

Powered by Google App Engine
This is Rietveld 408576698