Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt

Issue 709193003: Don't require getPropertyCSSValue in css3-text getComputedStyle tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt ('k') | LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt
diff --git a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt
index bad687c6ad692249e1a918bd73245e2cb8d1d23a..e3b77143d11cf618e5c9ce7029b21e23c2112f84 100644
--- a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt
+++ b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt
@@ -1,94 +1,54 @@
-Test to make sure text-decoration-style property returns CSSPrimitiveValue properly.
+Test to make sure text-decoration-style is computed properly.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Ancestor should not inherit 'dashed' value from parent (fallback to initial 'solid' value):
-PASS e.style.getPropertyCSSValue('text-decoration-style') is null
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'solid'
-PASS computedStyle.textDecorationStyle is 'solid'
+PASS e.style.textDecorationStyle is ""
+PASS computedStyle.textDecorationStyle is "solid"
Parent should cointain 'dashed':
-PASS e.style.textDecorationStyle is 'dashed'
-PASS e.style.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-style').cssText is 'dashed'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'dashed'
-PASS computedStyle.textDecorationStyle is 'dashed'
+PASS e.style.textDecorationStyle is "dashed"
+PASS computedStyle.textDecorationStyle is "dashed"
JavaScript setter tests for valid, initial, invalid and blank values:
-PASS e.style.getPropertyCSSValue('text-decoration-style') is null
+PASS e.style.textDecorationStyle is ""
Valid value 'solid':
-PASS e.style.textDecorationStyle is 'solid'
-PASS e.style.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-style').cssText is 'solid'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'solid'
-PASS computedStyle.textDecorationStyle is 'solid'
+PASS e.style.textDecorationStyle is "solid"
+PASS computedStyle.textDecorationStyle is "solid"
Valid value 'double':
-PASS e.style.textDecorationStyle is 'double'
-PASS e.style.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-style').cssText is 'double'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'double'
-PASS computedStyle.textDecorationStyle is 'double'
+PASS e.style.textDecorationStyle is "double"
+PASS computedStyle.textDecorationStyle is "double"
Valid value 'dotted':
-PASS e.style.textDecorationStyle is 'dotted'
-PASS e.style.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-style').cssText is 'dotted'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'dotted'
-PASS computedStyle.textDecorationStyle is 'dotted'
+PASS e.style.textDecorationStyle is "dotted"
+PASS computedStyle.textDecorationStyle is "dotted"
Valid value 'dashed':
-PASS e.style.textDecorationStyle is 'dashed'
-PASS e.style.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-style').cssText is 'dashed'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'dashed'
-PASS computedStyle.textDecorationStyle is 'dashed'
+PASS e.style.textDecorationStyle is "dashed"
+PASS computedStyle.textDecorationStyle is "dashed"
Valid value 'wavy':
-PASS e.style.textDecorationStyle is 'wavy'
-PASS e.style.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-style').cssText is 'wavy'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'wavy'
-PASS computedStyle.textDecorationStyle is 'wavy'
+PASS e.style.textDecorationStyle is "wavy"
+PASS computedStyle.textDecorationStyle is "wavy"
Initial value:
-PASS e.style.textDecorationStyle is 'initial'
-PASS e.style.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-style').cssText is 'initial'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'solid'
-PASS computedStyle.textDecorationStyle is 'solid'
+PASS e.style.textDecorationStyle is "initial"
+PASS computedStyle.textDecorationStyle is "solid"
Invalid value (this property accepts one value at a time only):
-PASS e.style.textDecorationStyle is 'initial'
-PASS e.style.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-style').cssText is 'initial'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'solid'
-PASS computedStyle.textDecorationStyle is 'solid'
+PASS e.style.textDecorationStyle is "initial"
+PASS computedStyle.textDecorationStyle is "solid"
Invalid value (ie. 'unknown'):
-PASS e.style.textDecorationStyle is 'initial'
-PASS e.style.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-style').cssText is 'initial'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'solid'
-PASS computedStyle.textDecorationStyle is 'solid'
+PASS e.style.textDecorationStyle is "initial"
+PASS computedStyle.textDecorationStyle is "solid"
Empty value (resets the property):
-PASS e.style.getPropertyCSSValue('text-decoration-style') is null
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-style').cssText is 'solid'
-PASS computedStyle.textDecorationStyle is 'solid'
+PASS e.style.textDecorationStyle is ""
+PASS computedStyle.textDecorationStyle is "solid"
PASS successfullyParsed is true
« no previous file with comments | « LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt ('k') | LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698