Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt

Issue 709193003: Don't require getPropertyCSSValue in css3-text getComputedStyle tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt
diff --git a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt
index 5c9f565c46110ba044641794e2b9ab7acc047e6f..f3200b73a98cd7da950d78f2cc43a8d923b7ccb5 100644
--- a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt
+++ b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt
@@ -1,100 +1,58 @@
-Test to make sure text-decoration-color property returns CSSPrimitiveValue properly.
+Test to make sure text-decoration-color is computed properly.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Ancestor should not inherit 'green' value from parent (fallback to initial value):
-PASS e.style.getPropertyCSSValue('text-decoration-color') is null
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 0, 0)'
-PASS computedStyle.textDecorationColor is 'rgb(0, 0, 0)'
+PASS e.style.textDecorationColor is ""
+PASS computedStyle.textDecorationColor is "rgb(0, 0, 0)"
Parent should contain 'green':
-PASS e.style.textDecorationColor is 'green'
-PASS e.style.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-color').cssText is 'green'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 128, 0)'
-PASS computedStyle.textDecorationColor is 'rgb(0, 128, 0)'
+PASS e.style.textDecorationColor is "green"
+PASS computedStyle.textDecorationColor is "rgb(0, 128, 0)"
JavaScript setter tests for valid, initial, invalid and blank values:
-PASS e.style.getPropertyCSSValue('text-decoration-color') is null
+PASS e.style.textDecorationColor is ""
Valid value 'blue':
-PASS e.style.textDecorationColor is 'blue'
-PASS e.style.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-color').cssText is 'blue'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 0, 255)'
-PASS computedStyle.textDecorationColor is 'rgb(0, 0, 255)'
+PASS e.style.textDecorationColor is "blue"
+PASS computedStyle.textDecorationColor is "rgb(0, 0, 255)"
Valid value '#FFFFFF':
-PASS e.style.textDecorationColor is 'rgb(255, 255, 255)'
-PASS e.style.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(255, 255, 255)'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(255, 255, 255)'
-PASS computedStyle.textDecorationColor is 'rgb(255, 255, 255)'
+PASS e.style.textDecorationColor is "rgb(255, 255, 255)"
+PASS computedStyle.textDecorationColor is "rgb(255, 255, 255)"
Valid value 'rgb(0, 255, 0)':
-PASS e.style.textDecorationColor is 'rgb(0, 255, 0)'
-PASS e.style.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 255, 0)'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 255, 0)'
-PASS computedStyle.textDecorationColor is 'rgb(0, 255, 0)'
+PASS e.style.textDecorationColor is "rgb(0, 255, 0)"
+PASS computedStyle.textDecorationColor is "rgb(0, 255, 0)"
Valid value 'rgba(100, 100, 100, 0.5)':
-PASS e.style.textDecorationColor is 'rgba(100, 100, 100, 0.498039)'
-PASS e.style.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-color').cssText is 'rgba(100, 100, 100, 0.498039)'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgba(100, 100, 100, 0.498039)'
-PASS computedStyle.textDecorationColor is 'rgba(100, 100, 100, 0.498039)'
+PASS e.style.textDecorationColor is "rgba(100, 100, 100, 0.498039)"
+PASS computedStyle.textDecorationColor is "rgba(100, 100, 100, 0.498039)"
Valid value 'hsl(240, 100%, 50%)':
-PASS e.style.textDecorationColor is 'rgb(0, 0, 255)'
-PASS e.style.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 0, 255)'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 0, 255)'
-PASS computedStyle.textDecorationColor is 'rgb(0, 0, 255)'
+PASS e.style.textDecorationColor is "rgb(0, 0, 255)"
+PASS computedStyle.textDecorationColor is "rgb(0, 0, 255)"
Valid value 'hsla(240, 100%, 50%, 0.5)':
-PASS e.style.textDecorationColor is 'rgba(0, 0, 255, 0.498039)'
-PASS e.style.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-color').cssText is 'rgba(0, 0, 255, 0.498039)'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgba(0, 0, 255, 0.498039)'
-PASS computedStyle.textDecorationColor is 'rgba(0, 0, 255, 0.498039)'
+PASS e.style.textDecorationColor is "rgba(0, 0, 255, 0.498039)"
+PASS computedStyle.textDecorationColor is "rgba(0, 0, 255, 0.498039)"
Initial value:
-PASS e.style.textDecorationColor is 'initial'
-PASS e.style.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-color').cssText is 'initial'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 0, 0)'
-PASS computedStyle.textDecorationColor is 'rgb(0, 0, 0)'
+PASS e.style.textDecorationColor is "initial"
+PASS computedStyle.textDecorationColor is "rgb(0, 0, 0)"
Invalid value (ie. 'unknown'):
-PASS e.style.textDecorationColor is 'initial'
-PASS e.style.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSValue]'
-PASS e.style.getPropertyCSSValue('text-decoration-color').cssText is 'initial'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 0, 0)'
-PASS computedStyle.textDecorationColor is 'rgb(0, 0, 0)'
+PASS e.style.textDecorationColor is "initial"
+PASS computedStyle.textDecorationColor is "rgb(0, 0, 0)"
Empty value (resets the property):
-PASS e.style.getPropertyCSSValue('text-decoration-color') is null
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 0, 0)'
-PASS computedStyle.textDecorationColor is 'rgb(0, 0, 0)'
+PASS e.style.textDecorationColor is ""
+PASS computedStyle.textDecorationColor is "rgb(0, 0, 0)"
Empty value with different 'currentColor' initial value (green):
-PASS e.style.getPropertyCSSValue('text-decoration-color') is null
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').toString() is '[object CSSPrimitiveValue]'
-PASS computedStyle.getPropertyCSSValue('text-decoration-color').cssText is 'rgb(0, 128, 0)'
-PASS computedStyle.textDecorationColor is 'rgb(0, 128, 0)'
+PASS e.style.textDecorationColor is ""
+PASS computedStyle.textDecorationColor is "rgb(0, 128, 0)"
PASS successfullyParsed is true

Powered by Google App Engine
This is Rietveld 408576698