Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 703303003: Add GrGpuResource::CacheAccess (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@nohash
Project:
skia
Visibility:
Public.

Description

Add GrGpuResource::CacheAccess Internal only helper class for manipulating and accessing cache keys. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/453cf40ac7702722695bb09ae2c6df44c19d008b

Patch Set 1 #

Patch Set 2 : update #

Total comments: 6

Patch Set 3 : Address comments #

Patch Set 4 : rebase #

Patch Set 5 : fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -78 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrGpuResource.h View 4 chunks +10 lines, -20 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 2 3 2 chunks +0 lines, -18 lines 0 comments Download
A src/gpu/GrGpuResourceCacheAccess.h View 1 2 1 chunk +96 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 7 chunks +14 lines, -12 lines 0 comments Download
M src/gpu/GrResourceCache2.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrResourceCache2.cpp View 1 2 3 chunks +9 lines, -20 lines 0 comments Download
M src/gpu/GrStencilBuffer.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bsalomon
Follow up to https://codereview.chromium.org/705413002/
6 years, 1 month ago (2014-11-10 18:43:45 UTC) #2
robertphillips
lgtm with dox suggestion, nit & question https://codereview.chromium.org/703303003/diff/20001/src/gpu/GrGpuResourceCacheAccess.h File src/gpu/GrGpuResourceCacheAccess.h (right): https://codereview.chromium.org/703303003/diff/20001/src/gpu/GrGpuResourceCacheAccess.h#newcode13 src/gpu/GrGpuResourceCacheAccess.h:13: // This ...
6 years, 1 month ago (2014-11-11 15:20:52 UTC) #3
bsalomon
https://codereview.chromium.org/703303003/diff/20001/src/gpu/GrGpuResourceCacheAccess.h File src/gpu/GrGpuResourceCacheAccess.h (right): https://codereview.chromium.org/703303003/diff/20001/src/gpu/GrGpuResourceCacheAccess.h#newcode13 src/gpu/GrGpuResourceCacheAccess.h:13: On 2014/11/11 15:20:52, robertphillips wrote: > // This class ...
6 years, 1 month ago (2014-11-11 15:32:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703303003/60001
6 years, 1 month ago (2014-11-11 16:41:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/543)
6 years, 1 month ago (2014-11-11 16:43:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703303003/80001
6 years, 1 month ago (2014-11-11 22:05:20 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 22:16:01 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/453cf40ac7702722695bb09ae2c6df44c19d008b

Powered by Google App Engine
This is Rietveld 408576698