Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 69883003: Issue 249. Show documentation for highlighted code completion. (Closed)

Created:
7 years, 1 month ago by scheglov
Modified:
7 years, 1 month ago
Reviewers:
messick, pquitslund
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Issue 249. Show documentation for highlighted code completion. https://code.google.com/p/dart/issues/detail?id=249 Also hover and this new documentation popup is now sticky, i.e. make itself scrollable once user clicks it. R=messick@google.com, pquitslund@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30199

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -1344 lines) Patch
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java View 3 chunks +3 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionProposal.java View 3 chunks +6 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/completion/CompletionProposalImpl.java View 4 chunks +13 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/completion/CompletionProposal.java View 2 chunks +8 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ProxyProposal.java View 2 chunks +6 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java View 2 chunks +11 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/DartdocHoverStyleSheet.css View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/contentassist/VariableNamesProcessor.java View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/AbstractDartCompletionProposal.java View 7 chunks +71 lines, -60 lines 1 comment Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/DartCompletionProposal.java View 8 chunks +48 lines, -28 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/DartMethodCompletionProposal.java View 2 chunks +0 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/DartTypeCompletionProposal.java View 5 chunks +8 lines, -4 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/FieldProposalInfo.java View 1 chunk +0 lines, -72 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/GetterSetterCompletionProposal.java View 1 chunk +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/InlineFunctionCompletionProposal.java View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/LazyDartCompletionProposal.java View 2 chunks +5 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/LazyDartTypeCompletionProposal.java View 3 chunks +14 lines, -14 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MemberProposalInfo.java View 1 chunk +0 lines, -72 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MethodDeclarationCompletionProposal.java View 2 chunks +3 lines, -2 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MethodProposalInfo.java View 1 chunk +0 lines, -222 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/OverrideCompletionProposal.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/ParameterGuessingProposal.java View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/ProposalInfo.java View 2 chunks +9 lines, -114 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/TypeProposalInfo.java View 1 chunk +0 lines, -57 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartTypeCompletionProposalComputer.java View 2 chunks +4 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartTextHover.java View 2 chunks +23 lines, -19 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/html/BrowserInformationControl.java View 1 chunk +0 lines, -642 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/DartSourceViewerConfiguration.java View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalCollector.java View 8 chunks +41 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 1 month ago (2013-11-12 05:13:01 UTC) #1
messick
lgtm See the comment (with screenshot) on issue 249.
7 years, 1 month ago (2013-11-12 11:35:15 UTC) #2
pquitslund
LGTM. This is awesome and will be super helpful. (I'm sure Luke will concur!) https://codereview.chromium.org/69883003/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/AbstractDartCompletionProposal.java ...
7 years, 1 month ago (2013-11-12 16:47:44 UTC) #3
scheglov
7 years, 1 month ago (2013-11-12 18:49:42 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r30199 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698