Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java

Issue 69883003: Issue 249. Show documentation for highlighted code completion. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
index 08f92f6449ca7b16a96d0b64ef83bc4e721d193f..dfb10a79c6398e2fd89141fd91e929dfa0dd8cc6 100644
--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
@@ -2312,6 +2312,7 @@ public class CompletionEngine {
setParameterInfo(element, prop);
prop.setCompletion(name).setReturnType(element.getType().getReturnType().getName());
+ prop.setElement(element);
// If there is already argument list, then update only method name.
if (identifier.getParent() instanceof MethodInvocation
@@ -2334,6 +2335,7 @@ public class CompletionEngine {
return; // Simple constructors are not handled here
}
CompletionProposal prop = createProposal(element);
+ prop.setElement(element);
if (element.getType() != null) {
prop.setReturnType(element.getType().getName());
}
@@ -2354,6 +2356,7 @@ public class CompletionEngine {
return;
}
CompletionProposal prop = createProposal(element);
+ prop.setElement(element);
Element container = element.getEnclosingElement();
prop.setDeclaringType(container.getDisplayName());
requestor.accept(prop);

Powered by Google App Engine
This is Rietveld 408576698