editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartTypeCompletionProposalComputer.java - Issue 69883003: Issue 249. Show documentation for highlighted code completion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartTypeCompletionProposalComputer.java

Issue 69883003: Issue 249. Show documentation for highlighted code completion. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/AbstractDartCompletionProposal.java ('K') | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/TypeProposalInfo.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartTextHover.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartTypeCompletionProposalComputer.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartTypeCompletionProposalComputer.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartTypeCompletionProposalComputer.java

index 54d6fe704a98afbfa2803098890e45675360eff6..670fada2fbac27ff0f2249231a4088fdcca18a25 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartTypeCompletionProposalComputer.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartTypeCompletionProposalComputer.java

@@ -15,7 +15,6 @@ package com.google.dart.tools.ui.internal.text.dart;

import com.google.dart.tools.core.DartCore;

import com.google.dart.tools.core.completion.CompletionProposal;

-import com.google.dart.tools.core.model.DartElement;

import com.google.dart.tools.core.model.DartModelException;

import com.google.dart.tools.core.model.DartProject;

import com.google.dart.tools.core.model.Type;

@@ -73,10 +72,10 @@ public class DartTypeCompletionProposalComputer extends DartCompletionProposalCo

Set proposed = new HashSet();

for (Iterator it = types.iterator(); it.hasNext();) {

AbstractDartCompletionProposal p = (AbstractDartCompletionProposal) it.next();

- DartElement element = p.getDartElement();

- if (element instanceof Type) {

- proposed.add(((Type) element).getElementName());

- }

+// DartElement element = p.getDartElement();

+// if (element instanceof Type) {

+// proposed.add(((Type) element).getElementName());

+// }

relevance = Math.min(relevance, p.getRelevance());

}