editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/LazyDartCompletionProposal.java - Issue 69883003: Issue 249. Show documentation for highlighted code completion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/LazyDartCompletionProposal.java

Issue 69883003: Issue 249. Show documentation for highlighted code completion. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/AbstractDartCompletionProposal.java ('K') | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/InlineFunctionCompletionProposal.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/LazyDartTypeCompletionProposal.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/LazyDartCompletionProposal.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/LazyDartCompletionProposal.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/LazyDartCompletionProposal.java

index 4db78dc5ee337e86ae5ed0b815e7b11572098b59..0f6c36982e01c85d1cf16f8e5e74f2898bc7712b 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/LazyDartCompletionProposal.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/LazyDartCompletionProposal.java

@@ -13,11 +13,13 @@

package com.google.dart.tools.ui.internal.text.completion;

+import com.google.dart.engine.element.Element;

import com.google.dart.tools.core.completion.CompletionProposal;

import com.google.dart.tools.core.formatter.DefaultCodeFormatterConstants;

import com.google.dart.tools.core.model.CompilationUnit;

import com.google.dart.tools.core.model.DartProject;

import com.google.dart.tools.ui.DartToolsPlugin;

+import com.google.dart.tools.ui.internal.text.editor.DartTextHover;

import com.google.dart.tools.ui.text.dart.DartContentAssistInvocationContext;

import com.google.dart.tools.ui.text.editor.tmp.JavaScriptCore;

import com.google.dart.tools.ui.text.editor.tmp.Signature;

@@ -393,7 +395,9 @@ public class LazyDartCompletionProposal extends AbstractDartCompletionProposal {

}

protected ProposalInfo computeProposalInfo() {

- return null;

+ Element element = fProposal.getElement();

+ String html = DartTextHover.getElementDocumentationHtml(element);

+ return new ProposalInfo(fProposal, html);

}

protected int computeRelevance() {