editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MethodDeclarationCompletionProposal.java - Issue 69883003: Issue 249. Show documentation for highlighted code completion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MethodDeclarationCompletionProposal.java

Issue 69883003: Issue 249. Show documentation for highlighted code completion. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/AbstractDartCompletionProposal.java ('K') | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MemberProposalInfo.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MethodProposalInfo.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MethodDeclarationCompletionProposal.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MethodDeclarationCompletionProposal.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MethodDeclarationCompletionProposal.java

index d14cb72be1fafa385683ce33489c38928c17d5ff..47d9d71119f66a02fddac461bd03955eb8438b2d 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MethodDeclarationCompletionProposal.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/MethodDeclarationCompletionProposal.java

@@ -117,7 +117,7 @@ public class MethodDeclarationCompletionProposal extends DartTypeCompletionPropo

public MethodDeclarationCompletionProposal(Type type, String methodName, String returnTypeSig,

int start, int length, int relevance) {

super(

- "", type.getCompilationUnit(), start, length, null, getDisplayName(methodName, returnTypeSig), relevance); //$NON-NLS-1$

+ "", type.getCompilationUnit(), start, length, null, getDisplayName(methodName, returnTypeSig), relevance, null); //$NON-NLS-1$

Assert.isNotNull(type);

Assert.isNotNull(methodName);

@@ -126,7 +126,8 @@ public class MethodDeclarationCompletionProposal extends DartTypeCompletionPropo

fReturnTypeSig = returnTypeSig;

if (returnTypeSig == null) {

- setProposalInfo(new ProposalInfo(type));

+ // TODO(scheglov) implement documentation comment

+// setProposalInfo(new ProposalInfo(type));

ImageDescriptor desc = new DartElementImageDescriptor(

DartPluginImages.DESC_MISC_PUBLIC,