Issue 698543006: Drop support for this.exports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 698543006: Drop support for this.exports (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Drop support for this.exports Please use module.exports instead. As far as I know, all code in the repo has been converted over to the new style. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bcdf25554932619d5ab41c7eced0e236b15fb240

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -4 lines)			Patch
M	sky/engine/bindings/core/v8/ScriptController.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sky/engine/bindings/core/v8/V8ScriptRunner.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/bindings/core/v8/V8ScriptRunner.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

6 years, 1 month ago (2014-10-31 22:02:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bcdf25554932619d5ab41c7eced0e236b15fb240 (presubmit successful).