Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 698543006: Drop support for this.exports (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Drop support for this.exports Please use module.exports instead. As far as I know, all code in the repo has been converted over to the new style. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bcdf25554932619d5ab41c7eced0e236b15fb240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8ScriptRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8ScriptRunner.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-31 21:51:41 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-10-31 21:52:47 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-10-31 22:02:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bcdf25554932619d5ab41c7eced0e236b15fb240 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698