Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: sky/engine/bindings/core/v8/ScriptController.cpp

Issue 698543006: Drop support for this.exports (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/V8ScriptRunner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/ScriptController.cpp
diff --git a/sky/engine/bindings/core/v8/ScriptController.cpp b/sky/engine/bindings/core/v8/ScriptController.cpp
index a020cb3f92646765f6c541c31ce414e53012cb9c..af3e490d95abd4d6608a63dbdd9a5b2cf992b27a 100644
--- a/sky/engine/bindings/core/v8/ScriptController.cpp
+++ b/sky/engine/bindings/core/v8/ScriptController.cpp
@@ -347,7 +347,8 @@ void ScriptController::executeModuleScript(Document& document, const String& sou
V8ScriptModule module;
module.resourceName = document.url().string();
module.textPosition = textPosition;
- module.receiver = toV8(&document, context->Global(), m_isolate);
+ // FIXME: This should be the actual module object instead of the document.
+ module.moduleObject = toV8(&document, context->Global(), m_isolate);
module.source = source;
if (HTMLImport* parent = document.import()) {
« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/V8ScriptRunner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698