Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: sky/engine/bindings/core/v8/V8ScriptRunner.cpp

Issue 698543006: Drop support for this.exports (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/V8ScriptRunner.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 module.textPosition, 217 module.textPosition,
218 isolate, 218 isolate,
219 V8CacheOptionsOff); 219 V8CacheOptionsOff);
220 220
221 if (script.IsEmpty()) 221 if (script.IsEmpty())
222 return; 222 return;
223 223
224 v8::Handle<v8::Value> scriptResult = script->Run(); 224 v8::Handle<v8::Value> scriptResult = script->Run();
225 225
226 auto arguments = module.resolvedDependencies; 226 auto arguments = module.resolvedDependencies;
227 arguments.append(module.receiver); 227 arguments.append(module.moduleObject);
228 228
229 RELEASE_ASSERT(scriptResult->IsObject()); 229 RELEASE_ASSERT(scriptResult->IsObject());
230 scriptResult.As<v8::Object>()->CallAsFunction( 230 scriptResult.As<v8::Object>()->CallAsFunction(
231 module.receiver, arguments.size(), arguments.data()); 231 v8::Null(isolate), arguments.size(), arguments.data());
232 crashIfV8IsDead(); 232 crashIfV8IsDead();
233 } 233 }
234 234
235 } // namespace blink 235 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/bindings/core/v8/V8ScriptRunner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698