Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: sky/engine/bindings/core/v8/V8ScriptRunner.cpp

Issue 698543006: Drop support for this.exports (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/V8ScriptRunner.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/sky/engine/bindings/core/v8/V8ScriptRunner.cpp b/sky/engine/bindings/core/v8/V8ScriptRunner.cpp
index 9f6d746bf73117c74f057db1ed4c52a9347bab47..f06e697100112c4bdc33b7f297f686f6faf82961 100644
--- a/sky/engine/bindings/core/v8/V8ScriptRunner.cpp
+++ b/sky/engine/bindings/core/v8/V8ScriptRunner.cpp
@@ -224,11 +224,11 @@ void V8ScriptRunner::runModule(v8::Isolate* isolate, ExecutionContext* context,
v8::Handle<v8::Value> scriptResult = script->Run();
auto arguments = module.resolvedDependencies;
- arguments.append(module.receiver);
+ arguments.append(module.moduleObject);
RELEASE_ASSERT(scriptResult->IsObject());
scriptResult.As<v8::Object>()->CallAsFunction(
- module.receiver, arguments.size(), arguments.data());
+ v8::Null(isolate), arguments.size(), arguments.data());
crashIfV8IsDead();
}
« no previous file with comments | « sky/engine/bindings/core/v8/V8ScriptRunner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698