Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: sky/engine/bindings/core/v8/ScriptController.cpp

Issue 698543006: Drop support for this.exports (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/V8ScriptRunner.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2009 Apple Inc. All rights reserved.
4 * Copyright (C) 2014 Opera Software ASA. All rights reserved. 4 * Copyright (C) 2014 Opera Software ASA. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions are 7 * modification, are permitted provided that the following conditions are
8 * met: 8 * met:
9 * 9 *
10 * * Redistributions of source code must retain the above copyright 10 * * Redistributions of source code must retain the above copyright
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 ScriptState::Scope scope(scriptState); 340 ScriptState::Scope scope(scriptState);
341 341
342 RefPtr<LocalFrame> protect(m_frame); 342 RefPtr<LocalFrame> protect(m_frame);
343 343
344 v8::TryCatch tryCatch; 344 v8::TryCatch tryCatch;
345 tryCatch.SetVerbose(true); 345 tryCatch.SetVerbose(true);
346 346
347 V8ScriptModule module; 347 V8ScriptModule module;
348 module.resourceName = document.url().string(); 348 module.resourceName = document.url().string();
349 module.textPosition = textPosition; 349 module.textPosition = textPosition;
350 module.receiver = toV8(&document, context->Global(), m_isolate); 350 // FIXME: This should be the actual module object instead of the document.
351 module.moduleObject = toV8(&document, context->Global(), m_isolate);
351 module.source = source; 352 module.source = source;
352 353
353 if (HTMLImport* parent = document.import()) { 354 if (HTMLImport* parent = document.import()) {
354 for (HTMLImport* child = parent->firstChild(); child; child = child->nex t()) { 355 for (HTMLImport* child = parent->firstChild(); child; child = child->nex t()) {
355 if (HTMLLinkElement* link = static_cast<HTMLImportChild*>(child)->li nk()) { 356 if (HTMLLinkElement* link = static_cast<HTMLImportChild*>(child)->li nk()) {
356 String name = link->as(); 357 String name = link->as();
357 if (!name.isEmpty()) { 358 if (!name.isEmpty()) {
358 module.formalDependencies.append(name); 359 module.formalDependencies.append(name);
359 v8::Handle<v8::Value> actual; 360 v8::Handle<v8::Value> actual;
360 if (child->document()) 361 if (child->document())
361 actual = child->document()->exports().v8Value(); 362 actual = child->document()->exports().v8Value();
362 if (actual.IsEmpty()) 363 if (actual.IsEmpty())
363 actual = v8::Undefined(m_isolate); 364 actual = v8::Undefined(m_isolate);
364 module.resolvedDependencies.append(actual); 365 module.resolvedDependencies.append(actual);
365 } 366 }
366 } 367 }
367 } 368 }
368 } 369 }
369 370
370 V8ScriptRunner::runModule(m_isolate, m_frame->document(), module); 371 V8ScriptRunner::runModule(m_isolate, m_frame->document(), module);
371 } 372 }
372 373
373 } // namespace blink 374 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/V8ScriptRunner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698