Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 698533003: Implement support for closing shadow DOM plugin placeholders. (Closed)

Created:
6 years, 1 month ago by jbroman
Modified:
6 years, 1 month ago
Reviewers:
esprehn, Mike West
CC:
arv+blink, Bernhard Bauer, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Implement support for closing shadow DOM plugin placeholders. This is based on the current heuristic in plugins::PluginPlaceholder::HidePlugin (components/plugins/renderer/plugin_placeholder.cc). Tests are added to ensure that the placeholder closing code works as expected, and to verify that the newly-added WebPluginPlaceholder method is respected. A crude UI is currently used; showing the X graphics currently used is blocked on deciding how to load image resources in this environment. BUG=364716 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184852

Patch Set 1 #

Total comments: 9

Patch Set 2 : rebase #

Patch Set 3 : mkwst comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -5 lines) Patch
A LayoutTests/fast/plugins/plugin-placeholder-close.html View 1 chunk +104 lines, -0 lines 0 comments Download
A LayoutTests/fast/plugins/plugin-placeholder-close-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download
M LayoutTests/fast/plugins/plugin-placeholder-structured.html View 1 chunk +9 lines, -4 lines 0 comments Download
M LayoutTests/fast/plugins/plugin-placeholder-structured-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/html/shadow/PluginPlaceholderElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/shadow/PluginPlaceholderElement.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/shadow/PluginPlaceholderElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/shadow/PluginPlaceholderElement.js View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
M Source/core/plugins/testing/DictionaryPluginPlaceholder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/web/PluginPlaceholderImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/PluginPlaceholderImplTest.cpp View 1 2 3 chunks +39 lines, -1 line 0 comments Download
M public/web/WebPluginPlaceholder.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
jbroman
I'm not thrilled with this heuristic, but it's what we do now and it seems ...
6 years, 1 month ago (2014-10-31 17:31:32 UTC) #2
esprehn
Can you just use a data url for the image?
6 years, 1 month ago (2014-10-31 17:37:09 UTC) #3
jbroman
On 2014/10/31 17:37:09, esprehn wrote: > Can you just use a data url for the ...
6 years, 1 month ago (2014-10-31 17:49:47 UTC) #4
Mike West
Regarding the image resources, I think it's reasonable for private script to be considered part ...
6 years, 1 month ago (2014-11-02 14:01:44 UTC) #5
jbroman
On 2014/11/02 14:01:44, Mike West wrote: > Regarding the image resources, I think it's reasonable ...
6 years, 1 month ago (2014-11-03 16:20:36 UTC) #6
Mike West
I'll take a closer look at your comments in the morning (sorry, running out the ...
6 years, 1 month ago (2014-11-03 16:35:46 UTC) #7
jbroman
On 2014/11/03 16:35:46, Mike West wrote: > I'll take a closer look at your comments ...
6 years, 1 month ago (2014-11-03 16:43:53 UTC) #8
Mike West
LGTM, thanks for filing the bugs.
6 years, 1 month ago (2014-11-04 15:10:56 UTC) #9
jbroman
On 2014/11/04 15:10:56, Mike West wrote: > LGTM, thanks for filing the bugs. Thanks. Will ...
6 years, 1 month ago (2014-11-04 20:52:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698533003/40001
6 years, 1 month ago (2014-11-05 07:11:55 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 07:15:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184852

Powered by Google App Engine
This is Rietveld 408576698