LayoutTests/fast/plugins/plugin-placeholder-structured.html - Issue 698533003: Implement support for closing shadow DOM plugin placeholders.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/plugins/plugin-placeholder-structured.html

Issue 698533003: Implement support for closing shadow DOM plugin placeholders. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: mkwst comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2	2

3 <!-- The message inserted below should be shown with some suitable style. -->	3 <style>

4 <object type="application/x-fake-plugin"></object>	4 applet, embed, object { display: block; }

	5 </style>

	6

	7 <!-- The placeholders inserted below should be shown with some suitable style. - ->

	8 <object id="plugin1" type="application/x-fake-plugin"></object>

	9 <object id="plugin2" type="application/x-fake-plugin"></object>

5	10

6 <script>	11 <script>

7 var plugin = document.querySelector("object");	12 internals.forcePluginPlaceholder(document.getElementById('plugin1'), { message: "Sorry, but your plugin couldn't be loaded." });

8 internals.forcePluginPlaceholder(plugin, { message: "Sorry, but your plugin coul dn't be loaded." });	13 internals.forcePluginPlaceholder(document.getElementById('plugin2'), { message: "Sorry, but your plugin couldn't be loaded.", closeable: true });

9 </script>	14 </script>

OLD	NEW