LayoutTests/fast/plugins/plugin-placeholder-structured.html - Issue 698533003: Implement support for closing shadow DOM plugin placeholders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/plugins/plugin-placeholder-structured.html

Issue 698533003: Implement support for closing shadow DOM plugin placeholders. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: mkwst comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/plugins/plugin-placeholder-structured.html

diff --git a/LayoutTests/fast/plugins/plugin-placeholder-structured.html b/LayoutTests/fast/plugins/plugin-placeholder-structured.html

index 168f0a8256fd3d679a669efaedd27b522a2c2e34..ed7698e09d0e96178668e1a2dce3d4126d2d565c 100644

--- a/LayoutTests/fast/plugins/plugin-placeholder-structured.html

+++ b/LayoutTests/fast/plugins/plugin-placeholder-structured.html

@@ -1,9 +1,14 @@

<!DOCTYPE html>

-

-<object type="application/x-fake-plugin"></object>

+<style>

+applet, embed, object { display: block; }

+</style>

+

+<object id="plugin1" type="application/x-fake-plugin"></object>

+<object id="plugin2" type="application/x-fake-plugin"></object>

-var plugin = document.querySelector("object");

-internals.forcePluginPlaceholder(plugin, { message: "Sorry, but your plugin couldn't be loaded." });

+internals.forcePluginPlaceholder(document.getElementById('plugin1'), { message: "Sorry, but your plugin couldn't be loaded." });

+internals.forcePluginPlaceholder(document.getElementById('plugin2'), { message: "Sorry, but your plugin couldn't be loaded.", closeable: true });

</script>