Source/core/plugins/testing/DictionaryPluginPlaceholder.h - Issue 698533003: Implement support for closing shadow DOM plugin placeholders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/plugins/testing/DictionaryPluginPlaceholder.h

Issue 698533003: Implement support for closing shadow DOM plugin placeholders. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: mkwst comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/plugins/testing/DictionaryPluginPlaceholder.h

diff --git a/Source/core/plugins/testing/DictionaryPluginPlaceholder.h b/Source/core/plugins/testing/DictionaryPluginPlaceholder.h

index fe38dd6c6fe4cd6a976c937055fb3fc21cb567b9..79124a48b393b5a79f8304cdf2c316d19af369d8 100644

--- a/Source/core/plugins/testing/DictionaryPluginPlaceholder.h

+++ b/Source/core/plugins/testing/DictionaryPluginPlaceholder.h

@@ -24,6 +24,10 @@ public:

if (DictionaryHelper::get(options, "message", stringValue))

placeholder->setMessage(stringValue);

+ bool booleanValue;

+ if (DictionaryHelper::get(options, "closeable", booleanValue))

+ placeholder->setIsCloseable(booleanValue);

return adoptPtrWillBeNoop(new DictionaryPluginPlaceholder(placeholder.release()));

}