Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 697223004: Do not try to link chrome or app_shell in chromeos gn build. (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
Chris Masone
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, brettw, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not try to link chrome or app_shell in chromeos gn build. On ChromeOS, Chrome links in the remoting host, which isn't gn-ified yet. I'm not quite sure why app_shell doesn't work, but it might be the same issue. TBR=cmasone@chromium.org BUG=424337 Committed: https://crrev.com/6fc75b3f8718593090cca2b4a6cba0e84122d201 Cr-Commit-Position: refs/heads/master@{#302524}

Patch Set 1 #

Patch Set 2 : Also, enable clang by default on ChromeOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M build/config/BUILDCONFIG.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Dirk Pranke
6 years, 1 month ago (2014-11-03 22:44:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697223004/1
6 years, 1 month ago (2014-11-03 22:46:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697223004/20001
6 years, 1 month ago (2014-11-03 22:50:42 UTC) #5
Chris Masone
If this is preferred place to do this, as opposed to in bot configs, then ...
6 years, 1 month ago (2014-11-03 22:57:52 UTC) #6
Dirk Pranke
On 2014/11/03 22:57:52, Chris Masone wrote: > If this is preferred place to do this, ...
6 years, 1 month ago (2014-11-03 22:59:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 00:04:11 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 00:04:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6fc75b3f8718593090cca2b4a6cba0e84122d201
Cr-Commit-Position: refs/heads/master@{#302524}

Powered by Google App Engine
This is Rietveld 408576698