Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4016)

Unified Diff: extensions/shell/BUILD.gn

Issue 697223004: Do not try to link chrome or app_shell in chromeos gn build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also, enable clang by default on ChromeOS Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/BUILD.gn
diff --git a/extensions/shell/BUILD.gn b/extensions/shell/BUILD.gn
index b667ba1c7682c98b3beb0830f3334b5634d67286..2861ae4981c4c4d522bec49bff4f7ddb16467f2a 100644
--- a/extensions/shell/BUILD.gn
+++ b/extensions/shell/BUILD.gn
@@ -127,14 +127,16 @@ source_set("app_shell_lib") {
}
}
-executable("app_shell") {
- # testonly because :app_shell_lib is testonly. See :app_shell_lib comment.
- testonly = true
- deps = [
- ":app_shell_lib",
- "//extensions:shell_and_test_pak",
- ]
- sources = [ "app/shell_main.cc" ]
+if (!is_chromeos) {
+ executable("app_shell") {
+ # testonly because :app_shell_lib is testonly. See :app_shell_lib comment.
+ testonly = true
+ deps = [
+ ":app_shell_lib",
+ "//extensions:shell_and_test_pak",
+ ]
+ sources = [ "app/shell_main.cc" ]
+ }
}
action("version_header") {
« no previous file with comments | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698