chrome/BUILD.gn - Issue 697223004: Do not try to link chrome or app_shell in chromeos gn build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 697223004: Do not try to link chrome or app_shell in chromeos gn build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also, enable clang by default on ChromeOS Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 90a5314823562044e45590d76d59f96745b7018f..ad58f0642a354f9204adb46dfbb0832532d2bb9f 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -12,7 +12,7 @@ if (is_android) {

import("//build/config/android/rules.gni")

}

-if (!is_android) {

+if (!is_android && !is_chromeos) {

# TODO(GYP) for Windows need to the the reorder-imports step which probably

# means adding another target and renaming this to chrome_initial like in GYP.

« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | extensions/shell/BUILD.gn » ('j') | no next file with comments »