Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Side by Side Diff: extensions/shell/BUILD.gn

Issue 697223004: Do not try to link chrome or app_shell in chromeos gn build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also, enable clang by default on ChromeOS Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//tools/grit/grit_rule.gni") 5 import("//tools/grit/grit_rule.gni")
6 6
7 assert(enable_extensions) 7 assert(enable_extensions)
8 8
9 grit("resources") { 9 grit("resources") {
10 source = "app_shell_resources.grd" 10 source = "app_shell_resources.grd"
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 ] 120 ]
121 if (is_chromeos) { 121 if (is_chromeos) {
122 deps += [ 122 deps += [
123 "//chromeos", 123 "//chromeos",
124 "//ui/chromeos:ui_chromeos", 124 "//ui/chromeos:ui_chromeos",
125 "//ui/display", 125 "//ui/display",
126 ] 126 ]
127 } 127 }
128 } 128 }
129 129
130 executable("app_shell") { 130 if (!is_chromeos) {
131 # testonly because :app_shell_lib is testonly. See :app_shell_lib comment. 131 executable("app_shell") {
132 testonly = true 132 # testonly because :app_shell_lib is testonly. See :app_shell_lib comment.
133 deps = [ 133 testonly = true
134 ":app_shell_lib", 134 deps = [
135 "//extensions:shell_and_test_pak", 135 ":app_shell_lib",
136 ] 136 "//extensions:shell_and_test_pak",
137 sources = [ "app/shell_main.cc" ] 137 ]
138 sources = [ "app/shell_main.cc" ]
139 }
138 } 140 }
139 141
140 action("version_header") { 142 action("version_header") {
141 script = "//build/util/version.py" 143 script = "//build/util/version.py"
142 version_path = "//chrome/VERSION" 144 version_path = "//chrome/VERSION"
143 lastchange_path = "//build/util/LASTCHANGE" 145 lastchange_path = "//build/util/LASTCHANGE"
144 version_h = "common/version.h.in" 146 version_h = "common/version.h.in"
145 version_full = exec_script( 147 version_full = exec_script(
146 script, 148 script,
147 ["-f", rebase_path(version_path, root_build_dir), 149 ["-f", rebase_path(version_path, root_build_dir),
148 "-t", "@MAJOR@.@MINOR@.@BUILD@.@PATCH@"], 150 "-t", "@MAJOR@.@MINOR@.@BUILD@.@PATCH@"],
149 "trim string", 151 "trim string",
150 ["VERSION"]) 152 ["VERSION"])
151 inputs = [ 153 inputs = [
152 lastchange_path, 154 lastchange_path,
153 version_path, 155 version_path,
154 version_h 156 version_h
155 ] 157 ]
156 outputs = [ "$target_gen_dir/common/version.h" ] 158 outputs = [ "$target_gen_dir/common/version.h" ]
157 args = [ 159 args = [
158 "-f", rebase_path(lastchange_path, root_build_dir), 160 "-f", rebase_path(lastchange_path, root_build_dir),
159 "-e", "VERSION_FULL=\"$version_full\"", 161 "-e", "VERSION_FULL=\"$version_full\"",
160 rebase_path(version_h, root_build_dir), 162 rebase_path(version_h, root_build_dir),
161 rebase_path("$target_gen_dir/common/version.h") 163 rebase_path("$target_gen_dir/common/version.h")
162 ] 164 ]
163 } 165 }
OLDNEW
« no previous file with comments | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698