build/config/BUILDCONFIG.gn - Issue 697223004: Do not try to link chrome or app_shell in chromeos gn build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILDCONFIG.gn

Issue 697223004: Do not try to link chrome or app_shell in chromeos gn build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also, enable clang by default on ChromeOS Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/BUILDCONFIG.gn

diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn

index 64878aa2ffc2a463a26f63f96b2af73f0df4979a..c9ec4a2f858aa7bbdbebcd01cee2e842c504c228 100644

--- a/build/config/BUILDCONFIG.gn

+++ b/build/config/BUILDCONFIG.gn

@@ -32,7 +32,7 @@ declare_args() {

# Set to true when compiling with the Clang compiler. Typically this is used

# to configure warnings.

- is_clang = (os == "mac" || os == "ios" || os == "linux")

+ is_clang = (os == "mac" || os == "ios" || os == "linux" || os == "chromeos")

# Forces a 64-bit build on Windows. Does nothing on other platforms. Normally

# we build 32-bit on Windows regardless of the current host OS bit depth.

« no previous file with comments | « no previous file | chrome/BUILD.gn » ('j') | no next file with comments »