Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 688993002: Oilpan: have Screen be on the heap by default. (Closed)

Created:
6 years, 1 month ago by sof
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: have Screen be on the heap by default. R=haraken BUG=479467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194367

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : non-oilpan compile fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M Source/core/frame/LocalDOMWindow.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Screen.h View 1 1 chunk +5 lines, -6 lines 2 comments Download
M Source/core/frame/Screen.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/Screen.idl View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/screen_orientation/ScreenScreenOrientation.h View 1 3 chunks +4 lines, -6 lines 0 comments Download
M Source/modules/screen_orientation/ScreenScreenOrientation.cpp View 1 2 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look.
5 years, 8 months ago (2015-04-24 08:16:35 UTC) #2
haraken
LGTM https://codereview.chromium.org/688993002/diff/40001/Source/core/frame/Screen.h File Source/core/frame/Screen.h (right): https://codereview.chromium.org/688993002/diff/40001/Source/core/frame/Screen.h#newcode42 Source/core/frame/Screen.h:42: // TODO(Oilpan): when ~DOMWindowProperty is removed, derive from ...
5 years, 8 months ago (2015-04-24 08:51:12 UTC) #4
sof
https://codereview.chromium.org/688993002/diff/40001/Source/core/frame/Screen.h File Source/core/frame/Screen.h (right): https://codereview.chromium.org/688993002/diff/40001/Source/core/frame/Screen.h#newcode42 Source/core/frame/Screen.h:42: // TODO(Oilpan): when ~DOMWindowProperty is removed, derive from GarbageCollected<> ...
5 years, 8 months ago (2015-04-24 08:53:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688993002/40001
5 years, 8 months ago (2015-04-24 09:56:35 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 10:00:14 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194367

Powered by Google App Engine
This is Rietveld 408576698