Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: Source/core/frame/Screen.h

Issue 688993002: Oilpan: have Screen be on the heap by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: non-oilpan compile fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/LocalDOMWindow.h ('k') | Source/core/frame/Screen.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 16 matching lines...) Expand all
27 */ 27 */
28 28
29 29
30 #ifndef Screen_h 30 #ifndef Screen_h
31 #define Screen_h 31 #define Screen_h
32 32
33 #include "bindings/core/v8/ScriptWrappable.h" 33 #include "bindings/core/v8/ScriptWrappable.h"
34 #include "core/frame/DOMWindowProperty.h" 34 #include "core/frame/DOMWindowProperty.h"
35 #include "platform/Supplementable.h" 35 #include "platform/Supplementable.h"
36 #include "platform/heap/Handle.h" 36 #include "platform/heap/Handle.h"
37 #include "wtf/PassRefPtr.h"
38 #include "wtf/RefCounted.h"
39 37
40 namespace blink { 38 namespace blink {
41 39
42 class LocalFrame; 40 class LocalFrame;
43 41
44 class Screen final : public RefCountedWillBeGarbageCollected<Screen>, public Scr iptWrappable, public DOMWindowProperty, public WillBeHeapSupplementable<Screen> { 42 // TODO(Oilpan): when ~DOMWindowProperty is removed, derive from GarbageCollecte d<> instead.
haraken 2015/04/24 08:51:11 TODO(sof)? I'm not sure if people want to have "Oi
sof 2015/04/24 08:53:27 I prefer using team/topic labels (if any) to simpl
43 class Screen final : public GarbageCollectedFinalized<Screen>, public ScriptWrap pable, public DOMWindowProperty, public HeapSupplementable<Screen> {
45 DEFINE_WRAPPERTYPEINFO(); 44 DEFINE_WRAPPERTYPEINFO();
46 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Screen); 45 USING_GARBAGE_COLLECTED_MIXIN(Screen);
47 public: 46 public:
48 static PassRefPtrWillBeRawPtr<Screen> create(LocalFrame* frame) 47 static Screen* create(LocalFrame* frame)
49 { 48 {
50 return adoptRefWillBeNoop(new Screen(frame)); 49 return new Screen(frame);
51 } 50 }
52 51
53 unsigned height() const; 52 unsigned height() const;
54 unsigned width() const; 53 unsigned width() const;
55 unsigned colorDepth() const; 54 unsigned colorDepth() const;
56 unsigned pixelDepth() const; 55 unsigned pixelDepth() const;
57 int availLeft() const; 56 int availLeft() const;
58 int availTop() const; 57 int availTop() const;
59 unsigned availHeight() const; 58 unsigned availHeight() const;
60 unsigned availWidth() const; 59 unsigned availWidth() const;
61 60
62 DECLARE_VIRTUAL_TRACE(); 61 DECLARE_VIRTUAL_TRACE();
63 62
64 private: 63 private:
65 explicit Screen(LocalFrame*); 64 explicit Screen(LocalFrame*);
66 }; 65 };
67 66
68 } // namespace blink 67 } // namespace blink
69 68
70 #endif // Screen_h 69 #endif // Screen_h
OLDNEW
« no previous file with comments | « Source/core/frame/LocalDOMWindow.h ('k') | Source/core/frame/Screen.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698