Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: Source/modules/screen_orientation/ScreenScreenOrientation.h

Issue 688993002: Oilpan: have Screen be on the heap by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: non-oilpan compile fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/screen_orientation/ScreenScreenOrientation.h
diff --git a/Source/modules/screen_orientation/ScreenScreenOrientation.h b/Source/modules/screen_orientation/ScreenScreenOrientation.h
index a2f2d30d3fec1a411c9741da2082f6acf04cacfb..e1c3da8c59340b0d0841dec587465b7a7a81ad3c 100644
--- a/Source/modules/screen_orientation/ScreenScreenOrientation.h
+++ b/Source/modules/screen_orientation/ScreenScreenOrientation.h
@@ -6,6 +6,7 @@
#define ScreenScreenOrientation_h
#include "platform/Supplementable.h"
+#include "platform/heap/Handle.h"
namespace blink {
@@ -13,13 +14,10 @@ class ScreenOrientation;
class Screen;
class ScriptState;
-class ScreenScreenOrientation final
- : public NoBaseWillBeGarbageCollectedFinalized<ScreenScreenOrientation>
- , public WillBeHeapSupplement<Screen> {
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ScreenScreenOrientation);
+class ScreenScreenOrientation final : public GarbageCollected<ScreenScreenOrientation>, public HeapSupplement<Screen> {
+ USING_GARBAGE_COLLECTED_MIXIN(ScreenScreenOrientation);
public:
static ScreenScreenOrientation& from(Screen&);
- virtual ~ScreenScreenOrientation();
static ScreenOrientation* orientation(ScriptState*, Screen&);
@@ -28,7 +26,7 @@ public:
private:
static const char* supplementName();
- PersistentWillBeMember<ScreenOrientation> m_orientation;
+ Member<ScreenOrientation> m_orientation;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698