Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 68893018: Rename es => exceptionState in bindings/ (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Rename es => exceptionState in bindings/ sed replace, basically: sed -ri 's/\<es\>([^-])/exceptionState\1/g' \ $(grep -rlE '\<es\>' *) Slightly tricky b/c some URLs using '#es-...' to link to Web IDL spec. TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -378 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 32 chunks +54 lines, -54 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_attributes.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_methods.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/attributes.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8SupportTestInterface.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObject.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 5 chunks +15 lines, -15 lines 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 25 chunks +74 lines, -74 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 10 chunks +31 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 7 chunks +21 lines, -21 lines 0 comments Download
M Source/bindings/v8/BindingSecurity.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 8 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8CryptoCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8DocumentCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/v8/custom/V8HistoryCustom.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8MessagePortCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8NodeCustom.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/bindings/v8/custom/V8SQLTransactionCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8SVGLengthCustom.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 10 chunks +27 lines, -27 lines 0 comments Download
M Source/bindings/v8/custom/V8WorkerCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 6 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/68893018/1
7 years, 1 month ago (2013-11-14 04:04:50 UTC) #1
Nils Barth (inactive)
(TBR)
7 years, 1 month ago (2013-11-14 04:16:11 UTC) #2
haraken
rubber-stamp LGTM. I just checked the code generator and several files.
7 years, 1 month ago (2013-11-14 04:23:52 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 1 month ago (2013-11-14 04:58:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/68893018/1
7 years, 1 month ago (2013-11-14 05:58:16 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 05:59:05 UTC) #6
Message was sent while issue was closed.
Change committed as 161993

Powered by Google App Engine
This is Rietveld 408576698