Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 68893018: Rename es => exceptionState in bindings/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/unstable/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp
index d39601ee4502f335705adbe921724087c9225e2c..3637a410ae93cdfdbb6c70ace36af74530342ee5 100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -28,17 +28,17 @@ static void {{attribute.name}}AttributeGetter{{world_suffix}}(const v8::Property
{# Special cases #}
{% if attribute.is_check_security_for_node %}
{# FIXME: consider using a local variable to not call getter twice #}
- ExceptionState es(info.GetIsolate());
- if (!BindingSecurity::shouldAllowAccessToNode({{attribute.cpp_value}}, es)) {
+ ExceptionState exceptionState(info.GetIsolate());
+ if (!BindingSecurity::shouldAllowAccessToNode({{attribute.cpp_value}}, exceptionState)) {
v8SetReturnValueNull(info);
- es.throwIfNeeded();
+ exceptionState.throwIfNeeded();
return;
}
{% endif %}
{% if attribute.is_getter_raises_exception %}
- ExceptionState es(info.GetIsolate());
+ ExceptionState exceptionState(info.GetIsolate());
{{attribute.cpp_type}} {{attribute.cpp_value}} = {{attribute.cpp_value_original}};
- if (UNLIKELY(es.throwIfNeeded()))
+ if (UNLIKELY(exceptionState.throwIfNeeded()))
return;
{% endif %}
{% if attribute.is_nullable %}
@@ -137,14 +137,14 @@ static void {{attribute.name}}AttributeSetter{{world_suffix}}(v8::Local<v8::Valu
CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
{% endif %}
{% if attribute.is_setter_raises_exception %}
- ExceptionState es(info.GetIsolate());
+ ExceptionState exceptionState(info.GetIsolate());
{% endif %}
{% if attribute.is_call_with_execution_context %}
ExecutionContext* scriptContext = getExecutionContext();
{% endif %}
{{attribute.cpp_setter}};
{% if attribute.is_setter_raises_exception %}
- es.throwIfNeeded();
+ exceptionState.throwIfNeeded();
{% endif %}
{% if attribute.cached_attribute_validation_method %}
info.Holder()->DeleteHiddenValue(v8::String::NewSymbol("{{attribute.name}}")); // Invalidate the cached value.
« no previous file with comments | « Source/bindings/scripts/unstable/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698