Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 68893018: Rename es => exceptionState in bindings/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/V8SupportTestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 3566e7383dac76a6b7bdf04d72fae02fc04927ef..c9ddcca88e218b8ead01c9e4620cfad338eac6b5 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -19,12 +19,12 @@ static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const
CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
{% endif %}
{% if method.is_raises_exception %}
- ExceptionState es(info.GetIsolate());
+ ExceptionState exceptionState(info.GetIsolate());
{% endif %}
{% if method.is_check_security_for_node %}
- if (!BindingSecurity::shouldAllowAccessToNode(imp->{{method.name}}(es), es)) {
+ if (!BindingSecurity::shouldAllowAccessToNode(imp->{{method.name}}(exceptionState), exceptionState)) {
v8SetReturnValueNull(info);
- es.throwIfNeeded();
+ exceptionState.throwIfNeeded();
return;
}
{% endif %}
@@ -104,9 +104,9 @@ static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const
%}
EventTarget* impl = {{v8_class_name}}::toNative(info.Holder());
if (DOMWindow* window = impl->toDOMWindow()) {
- ExceptionState es(info.GetIsolate());
- if (!BindingSecurity::shouldAllowAccessToFrame(window->frame(), es)) {
- es.throwIfNeeded();
+ ExceptionState exceptionState(info.GetIsolate());
+ if (!BindingSecurity::shouldAllowAccessToFrame(window->frame(), exceptionState)) {
+ exceptionState.throwIfNeeded();
return;
}
if (!window->document())
@@ -143,7 +143,7 @@ RefPtr<ScriptArguments> scriptArguments(createScriptArguments(info, {{method.num
{{method.cpp_type}} result = {{cpp_value}};
{% endif %}
{% if method.is_raises_exception %}
-if (es.throwIfNeeded())
+if (exceptionState.throwIfNeeded())
return;
{% endif %}
{% if method.is_call_with_script_state %}
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/V8SupportTestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698