Source/bindings/v8/V8Initializer.cpp - Issue 68893018: Rename es => exceptionState in bindings/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Initializer.cpp

Issue 68893018: Rename es => exceptionState in bindings/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/CustomElementConstructorBuilder.cpp ('k') | Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/V8Initializer.cpp

diff --git a/Source/bindings/v8/V8Initializer.cpp b/Source/bindings/v8/V8Initializer.cpp

index 73283dba0e16fc569d80d6cc8b6bcbef329a74c3..8335650a7aa375f430ce8e125b9c2a8f80f9857e 100644

--- a/Source/bindings/v8/V8Initializer.cpp

+++ b/Source/bindings/v8/V8Initializer.cpp

@@ -135,9 +135,9 @@ static void failedAccessCheckCallbackInMainThread(v8::Local<v8::Object> host, v8

return;

DOMWindow* targetWindow = target->domWindow();

- ExceptionState es(v8::Isolate::GetCurrent());

- es.throwSecurityError(targetWindow->sanitizedCrossDomainAccessErrorMessage(activeDOMWindow()), targetWindow->crossDomainAccessErrorMessage(activeDOMWindow()));

- es.throwIfNeeded();

+ ExceptionState exceptionState(v8::Isolate::GetCurrent());

+ exceptionState.throwSecurityError(targetWindow->sanitizedCrossDomainAccessErrorMessage(activeDOMWindow()), targetWindow->crossDomainAccessErrorMessage(activeDOMWindow()));

+ exceptionState.throwIfNeeded();

}

static bool codeGenerationCheckCallbackInMainThread(v8::Local<v8::Context> context)