Source/bindings/v8/custom/V8DocumentCustom.cpp - Issue 68893018: Rename es => exceptionState in bindings/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8DocumentCustom.cpp

Issue 68893018: Rename es => exceptionState in bindings/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp ('k') | Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8DocumentCustom.cpp

diff --git a/Source/bindings/v8/custom/V8DocumentCustom.cpp b/Source/bindings/v8/custom/V8DocumentCustom.cpp

index 6919bf145d23ef8822a42a00116d20cb46402bae..53708a14635558296b49b8360aeebd5fca080460 100644

--- a/Source/bindings/v8/custom/V8DocumentCustom.cpp

+++ b/Source/bindings/v8/custom/V8DocumentCustom.cpp

@@ -60,7 +60,7 @@ namespace WebCore {

void V8Document::evaluateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

{

RefPtr<Document> document = V8Document::toNative(info.Holder());

- ExceptionState es(info.GetIsolate());

+ ExceptionState exceptionState(info.GetIsolate());

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, expression, info[0]);

RefPtr<Node> contextNode;

if (V8Node::hasInstance(info[1], info.GetIsolate(), worldType(info.GetIsolate())))

@@ -77,8 +77,8 @@ void V8Document::evaluateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

if (V8XPathResult::hasInstance(info[4], info.GetIsolate(), worldType(info.GetIsolate())))

inResult = V8XPathResult::toNative(v8::Handle<v8::Object>::Cast(info[4]));

- V8TRYCATCH_VOID(RefPtr<XPathResult>, result, DocumentXPathEvaluator::evaluate(document.get(), expression, contextNode.get(), resolver.get(), type, inResult.get(), es));

- if (es.throwIfNeeded())

+ V8TRYCATCH_VOID(RefPtr<XPathResult>, result, DocumentXPathEvaluator::evaluate(document.get(), expression, contextNode.get(), resolver.get(), type, inResult.get(), exceptionState));

+ if (exceptionState.throwIfNeeded())

return;

v8SetReturnValueFast(info, result.release(), document.get());