Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 688213002: First pass at removing dead vertical writing mode code. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

First pass at removing dead vertical writing mode code. This just removes a random subset of vertical writing mode bits that I grepped for. There's a ton more to do, but it seems best to do it in chunks. The key things for understanding this patch, isWritingModeRoot is always false and isHorizontalWritingMode is always true. Also, we're never flipped* modes of any kind, so we can undo any flipping. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3e209b79959b36ca527beda6a796bf63d78a5ccb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -505 lines) Patch
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSProperty.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/FontBuilder.cpp View 1 chunk +3 lines, -29 lines 0 comments Download
M sky/engine/core/dom/Position.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M sky/engine/core/editing/VisiblePosition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +4 lines, -10 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 1 chunk +4 lines, -11 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/rendering/InlineBox.cpp View 1 chunk +8 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.h View 2 chunks +8 lines, -17 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/InlineTextBox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 14 chunks +21 lines, -75 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 8 chunks +17 lines, -73 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockLineLayout.cpp View 4 chunks +7 lines, -15 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 8 chunks +22 lines, -22 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 23 chunks +40 lines, -89 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 2 chunks +6 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.cpp View 4 chunks +3 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderReplaced.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RootInlineBox.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/line/BreakingContextInlineHeaders.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/line/LineWidth.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/shapes/BoxShapeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/shapes/Shape.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/shapes/Shape.cpp View 1 chunk +5 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 4 chunks +14 lines, -13 lines 0 comments Download
M sky/engine/platform/LengthBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/LengthBox.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M sky/engine/platform/geometry/LayoutBoxExtent.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/geometry/LayoutBoxExtent.cpp View 3 chunks +18 lines, -40 lines 0 comments Download
M sky/engine/platform/text/WritingMode.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-10-30 00:34:37 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-10-30 02:03:38 UTC) #3
ojan
6 years, 1 month ago (2014-10-30 02:07:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e209b79959b36ca527beda6a796bf63d78a5ccb.

Powered by Google App Engine
This is Rietveld 408576698