sky/engine/core/rendering/line/LineWidth.cpp - Issue 688213002: First pass at removing dead vertical writing mode code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/line/LineWidth.cpp

Issue 688213002: First pass at removing dead vertical writing mode code. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/engine/core/rendering/line/BreakingContextInlineHeaders.h ('k') | sky/engine/core/rendering/shapes/BoxShapeTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/rendering/line/LineWidth.cpp

diff --git a/sky/engine/core/rendering/line/LineWidth.cpp b/sky/engine/core/rendering/line/LineWidth.cpp

index 93dc921d9dd2ce71493f54415bffa23214859673..f511555694435032a3ea2dfb48bad954448f48eb 100644

--- a/sky/engine/core/rendering/line/LineWidth.cpp

+++ b/sky/engine/core/rendering/line/LineWidth.cpp

@@ -102,7 +102,7 @@ inline static bool isWholeLineFit(const RenderBlockFlow& block, const LayoutUnit

void LineWidth::wrapNextToShapeOutside(bool isFirstLine)

{

- LayoutUnit lineHeight = m_block.lineHeight(isFirstLine, m_block.isHorizontalWritingMode() ? HorizontalLine : VerticalLine, PositionOfInteriorLineBoxes);

+ LayoutUnit lineHeight = m_block.lineHeight(isFirstLine, HorizontalLine, PositionOfInteriorLineBoxes);

LayoutUnit lineLogicalTop = m_block.logicalHeight();

LayoutUnit newLineTop = lineLogicalTop;

LayoutUnit floatLogicalBottom = lineLogicalTop;

« no previous file with comments | « sky/engine/core/rendering/line/BreakingContextInlineHeaders.h ('k') | sky/engine/core/rendering/shapes/BoxShapeTest.cpp » ('j') | no next file with comments »