Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: sky/engine/platform/LengthBox.cpp

Issue 688213002: First pass at removing dead vertical writing mode code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/LengthBox.h ('k') | sky/engine/platform/geometry/LayoutBoxExtent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/LengthBox.cpp
diff --git a/sky/engine/platform/LengthBox.cpp b/sky/engine/platform/LengthBox.cpp
index c1341cda9250e0505ac373c419300a3763e23ef9..2c0da59193c1e521f0ee9b6000911ed7fef21467 100644
--- a/sky/engine/platform/LengthBox.cpp
+++ b/sky/engine/platform/LengthBox.cpp
@@ -35,12 +35,12 @@ namespace blink {
const Length& LengthBox::logicalLeft() const
{
- return isHorizontalWritingMode() ? m_left : m_top;
+ return m_left;
}
const Length& LengthBox::logicalRight() const
{
- return isHorizontalWritingMode() ? m_right : m_bottom;
+ return m_right;
}
const Length& LengthBox::before() const
@@ -57,16 +57,12 @@ const Length& LengthBox::after() const
const Length& LengthBox::start(TextDirection direction) const
{
- if (isHorizontalWritingMode())
- return isLeftToRightDirection(direction) ? m_left : m_right;
- return isLeftToRightDirection(direction) ? m_top : m_bottom;
+ return isLeftToRightDirection(direction) ? m_left : m_right;
}
const Length& LengthBox::end(TextDirection direction) const
{
- if (isHorizontalWritingMode())
- return isLeftToRightDirection(direction) ? m_right : m_left;
- return isLeftToRightDirection(direction) ? m_bottom : m_top;
+ return isLeftToRightDirection(direction) ? m_right : m_left;
}
} // namespace blink
« no previous file with comments | « sky/engine/platform/LengthBox.h ('k') | sky/engine/platform/geometry/LayoutBoxExtent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698