Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: sky/engine/core/rendering/RenderBoxModelObject.h

Issue 688213002: First pass at removing dead vertical writing mode code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/engine/core/rendering/RenderBoxModelObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderBoxModelObject.h
diff --git a/sky/engine/core/rendering/RenderBoxModelObject.h b/sky/engine/core/rendering/RenderBoxModelObject.h
index 8365f6c12e0991b2b71effd48cb3607b92ebca8c..8165edc3837d1ab38ed4210eee0e09518d98cf18 100644
--- a/sky/engine/core/rendering/RenderBoxModelObject.h
+++ b/sky/engine/core/rendering/RenderBoxModelObject.h
@@ -57,7 +57,7 @@ public:
virtual ~RenderBoxModelObject();
LayoutSize relativePositionOffset() const;
- LayoutSize relativePositionLogicalOffset() const { return style()->isHorizontalWritingMode() ? relativePositionOffset() : relativePositionOffset().transposedSize(); }
+ LayoutSize relativePositionLogicalOffset() const { return relativePositionOffset(); }
LayoutSize offsetForInFlowPosition() const;
@@ -119,16 +119,16 @@ public:
LayoutUnit borderAndPaddingWidth() const { return borderLeft() + borderRight() + paddingLeft() + paddingRight(); }
LayoutUnit borderAndPaddingLogicalHeight() const { return borderAndPaddingBefore() + borderAndPaddingAfter(); }
LayoutUnit borderAndPaddingLogicalWidth() const { return borderStart() + borderEnd() + paddingStart() + paddingEnd(); }
- LayoutUnit borderAndPaddingLogicalLeft() const { return style()->isHorizontalWritingMode() ? borderLeft() + paddingLeft() : borderTop() + paddingTop(); }
+ LayoutUnit borderAndPaddingLogicalLeft() const { return borderLeft() + paddingLeft(); }
- LayoutUnit borderLogicalLeft() const { return style()->isHorizontalWritingMode() ? borderLeft() : borderTop(); }
- LayoutUnit borderLogicalRight() const { return style()->isHorizontalWritingMode() ? borderRight() : borderBottom(); }
+ LayoutUnit borderLogicalLeft() const { return borderLeft(); }
+ LayoutUnit borderLogicalRight() const { return borderRight(); }
LayoutUnit borderLogicalWidth() const { return borderStart() + borderEnd(); }
LayoutUnit borderLogicalHeight() const { return borderBefore() + borderAfter(); }
- LayoutUnit paddingLogicalLeft() const { return style()->isHorizontalWritingMode() ? paddingLeft() : paddingTop(); }
- LayoutUnit paddingLogicalRight() const { return style()->isHorizontalWritingMode() ? paddingRight() : paddingBottom(); }
+ LayoutUnit paddingLogicalLeft() const { return paddingLeft(); }
+ LayoutUnit paddingLogicalRight() const { return paddingRight(); }
LayoutUnit paddingLogicalWidth() const { return paddingStart() + paddingEnd(); }
LayoutUnit paddingLogicalHeight() const { return paddingBefore() + paddingAfter(); }
« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/engine/core/rendering/RenderBoxModelObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698