sky/engine/core/editing/VisiblePosition.cpp - Issue 688213002: First pass at removing dead vertical writing mode code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/editing/VisiblePosition.cpp

Issue 688213002: First pass at removing dead vertical writing mode code. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/editing/VisiblePosition.cpp

diff --git a/sky/engine/core/editing/VisiblePosition.cpp b/sky/engine/core/editing/VisiblePosition.cpp

index 5acd451aaff3c16528fb3faa486442711e598d2d..7cfc49a72883bcd47ef13b1a5267158eea8d4db4 100644

--- a/sky/engine/core/editing/VisiblePosition.cpp

+++ b/sky/engine/core/editing/VisiblePosition.cpp

@@ -670,7 +670,7 @@ int VisiblePosition::lineDirectionPointForBlockDirectionNavigation() const

RenderObject* containingBlock = renderer->containingBlock();

if (!containingBlock)

containingBlock = renderer; // Just use ourselves to determine the writing mode if we have no containing block.

- return containingBlock->isHorizontalWritingMode() ? caretPoint.x() : caretPoint.y();

+ return caretPoint.x();

}

#ifndef NDEBUG

« no previous file with comments | « sky/engine/core/dom/Position.cpp ('k') | sky/engine/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »