Issue 688033003: Fix line numbers in JavaScript stack traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 688033003: Fix line numbers in JavaScript stack traces (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Fix line numbers in JavaScript stack traces Instead of calling the function constructor to compile script in Sky, we now concatenate strings. This has the advantage of making the line numbers generated in error messages correct but the disadvantage of being a hack. I've filed https://code.google.com/p/v8/issues/detail?id=3624 to request a proper API for this purpose. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ed2ec61ec4114a6c71b114522ed7c04194d474aa

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -28 lines)			Patch
M	sky/engine/bindings/core/v8/ScriptController.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/bindings/core/v8/ScriptController.cpp	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	sky/engine/bindings/core/v8/V8PerContextData.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sky/engine/bindings/core/v8/V8PerContextData.cpp	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/bindings/core/v8/V8ScriptRunner.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	sky/engine/bindings/core/v8/V8ScriptRunner.cpp	View		1 chunk	+27 lines, -9 lines	0 comments	Download
M	sky/engine/core/html/parser/HTMLScriptRunner.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/mutation-observer/mutation-record-nullity.sky	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/tests/mutation-observer/observe-subtree.sky	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/tests/parser/script-expected.txt	View		1 chunk	+7 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

esprehn

lgtm, This is how I feel about this patch: http://i.imgur.com/Rhb13yl.gif

6 years, 1 month ago (2014-10-29 20:59:24 UTC) #2

abarth-chromium

6 years, 1 month ago (2014-10-29 21:01:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ed2ec61ec4114a6c71b114522ed7c04194d474aa (presubmit successful).