sky/engine/core/html/parser/HTMLScriptRunner.cpp - Issue 688033003: Fix line numbers in JavaScript stack traces

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/engine/core/html/parser/HTMLScriptRunner.cpp

Issue 688033003: Fix line numbers in JavaScript stack traces (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Remove unnecessary Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « sky/engine/bindings/core/v8/V8ScriptRunner.cpp ('k') | sky/tests/mutation-observer/mutation-record-nullity.sky » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "config.h"	5 #include "config.h"

6 #include "core/html/parser/HTMLScriptRunner.h"	6 #include "core/html/parser/HTMLScriptRunner.h"

7	7

8 #include "bindings/core/v8/ScriptController.h"	8 #include "bindings/core/v8/ScriptController.h"

9 #include "core/dom/Document.h"	9 #include "core/dom/Document.h"

10 #include "core/dom/Microtask.h"	10 #include "core/dom/Microtask.h"

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 return;	52 return;

53	53

54 LocalFrame* frame = contextDocument->frame();	54 LocalFrame* frame = contextDocument->frame();

55 if (!frame)	55 if (!frame)

56 return;	56 return;

57	57

58 ASSERT(!m_isExecutingScript);	58 ASSERT(!m_isExecutingScript);

59 TemporaryChange<bool> executingScript(m_isExecutingScript, true);	59 TemporaryChange<bool> executingScript(m_isExecutingScript, true);

60	60

61 contextDocument->pushCurrentScript(element);	61 contextDocument->pushCurrentScript(element);

62 frame->script().executeModuleScript(sourceDocument, source);	62 frame->script().executeModuleScript(sourceDocument, source, textPosition);

63 contextDocument->popCurrentScript();	63 contextDocument->popCurrentScript();

64 }	64 }

65	65

66 }	66 }

OLD	NEW