sky/engine/bindings/core/v8/V8ScriptRunner.h - Issue 688033003: Fix line numbers in JavaScript stack traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/V8ScriptRunner.h

Issue 688033003: Fix line numbers in JavaScript stack traces (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Remove unnecessary Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/V8ScriptRunner.h

diff --git a/sky/engine/bindings/core/v8/V8ScriptRunner.h b/sky/engine/bindings/core/v8/V8ScriptRunner.h

index 3c02058fa7671db422ce3104f4981db3bc6b517c..1e4a1857fe116b0c45430b5ed76284b712f99b3d 100644

--- a/sky/engine/bindings/core/v8/V8ScriptRunner.h

+++ b/sky/engine/bindings/core/v8/V8ScriptRunner.h

@@ -38,8 +38,11 @@ class ScriptSourceCode;

class ExecutionContext;

struct V8ScriptModule {

+ String resourceName;

+ TextPosition textPosition;

v8::Handle<v8::Value> receiver;

- Vector<v8::Handle<v8::Value> > formalDependenciesAndSource;

+ String source;

+ Vector<String> formalDependencies;

Vector<v8::Handle<v8::Value> > resolvedDependencies;

};