sky/engine/bindings/core/v8/ScriptController.h - Issue 688033003: Fix line numbers in JavaScript stack traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/ScriptController.h

Issue 688033003: Fix line numbers in JavaScript stack traces (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Remove unnecessary Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/ScriptController.h

diff --git a/sky/engine/bindings/core/v8/ScriptController.h b/sky/engine/bindings/core/v8/ScriptController.h

index cb687f0228088386ffd182a872d3dc92ca90b5f1..929268ff908137c0a99693ee64853cd93c7a746d 100644

--- a/sky/engine/bindings/core/v8/ScriptController.h

+++ b/sky/engine/bindings/core/v8/ScriptController.h

@@ -72,7 +72,7 @@ public:

v8::Local<v8::Value> executeScriptInMainWorldAndReturnValue(const ScriptSourceCode&);

v8::Local<v8::Value> executeScriptAndReturnValue(v8::Handle<v8::Context>, const ScriptSourceCode&);

- void executeModuleScript(Document& document, const String& source);

+ void executeModuleScript(Document& document, const String& source, const TextPosition& textPosition);

// Executes JavaScript in an isolated world. The script gets its own global scope,

// its own prototypes for intrinsic JavaScript objects (String, Array, and so-on),

« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/ScriptController.cpp » ('j') | no next file with comments »